Re: [PATCH] netfilter/ipvs: clear ipvs_property flag when SKB net namesp

To: Julian Anastasov <ja@xxxxxx>
Subject: Re: [PATCH] netfilter/ipvs: clear ipvs_property flag when SKB net namespace changed
Cc: Ye Yin <hustcat@xxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, willemb@xxxxxxxxxx, edumazet@xxxxxxxxxx, johannes.berg@xxxxxxxxx, dcaratti@xxxxxxxxxx, pabeni@xxxxxxxxxx, f.fainelli@xxxxxxxxx, fw@xxxxxxxxx, soheil@xxxxxxxxxx, dwindsor@xxxxxxxxx, elena.reshetova@xxxxxxxxx, tom@xxxxxxxxxxxxxx, Jason@xxxxxxxxx, linux-kernel <linux-kernel@xxxxxxxxxxxxxxx>, netdev@xxxxxxxxxxxxxxx, Wei Zhou <chouryzhou@xxxxxxxxx>, Wensong Zhang <wensong@xxxxxxxxxxxx>, lvs-devel@xxxxxxxxxxxxxxx
From: Simon Horman <horms@xxxxxxxxxxxx>
Date: Thu, 2 Nov 2017 15:46:50 +0100
On Sat, Oct 28, 2017 at 01:33:09PM +0300, Julian Anastasov wrote:
>       Hello,
> On Thu, 26 Oct 2017, Ye Yin wrote:
> > When run ipvs in two different network namespace at the same host, and one
> > ipvs transport network traffic to the other network namespace ipvs.
> > 'ipvs_property' flag will make the second ipvs take no effect. So we should
> > clear 'ipvs_property' when SKB network namespace changed.
> > 
> > Signed-off-by: Ye Yin <hustcat@xxxxxxxxx>
> > Signed-off-by: Wei Zhou <chouryzhou@xxxxxxxxx>
>       Patch looks good to me. ipvs_property was added long ago
> but skb_scrub_packet() is more recent (3.11), so:
> Fixes: 621e84d6f373 ("dev: introduce skb_scrub_packet()")
> Signed-off-by: Julian Anastasov <ja@xxxxxx>
>       I guess, DaveM can apply it directly as a bugfix
> to the net tree.

Sounds like a good plan to me, Dave?

Signed-off-by: Simon Horman <horms@xxxxxxxxxxxx>

To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at

<Prev in Thread] Current Thread [Next in Thread>