Re: [PATCH net-next v2] ipvs: fix multiplicative hashing in sh/dh/lblc/l

To: Julian Anastasov <ja@xxxxxx>
Subject: Re: [PATCH net-next v2] ipvs: fix multiplicative hashing in sh/dh/lblc/lblcr algorithms
Cc: Vincent Bernat <vincent@xxxxxxxxx>, Wensong Zhang <wensong@xxxxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, netdev@xxxxxxxxxxxxxxx, lvs-devel@xxxxxxxxxxxxxxx
From: Simon Horman <horms@xxxxxxxxxxxx>
Date: Mon, 9 Apr 2018 10:16:23 +0300
On Sun, Apr 01, 2018 at 02:11:51PM +0300, Julian Anastasov wrote:
>       Hello,
> On Sun, 1 Apr 2018, Vincent Bernat wrote:
> > The sh/dh/lblc/lblcr algorithms are using Knuth's multiplicative
> > hashing incorrectly. Replace its use by the hash_32() macro, which
> > correctly implements this algorithm. It doesn't use the same constant,
> > but it shouldn't matter.
> > 
> > Signed-off-by: Vincent Bernat <vincent@xxxxxxxxx>
>       Looks good to me, thanks! Simon, please apply, if possible
> with the extra space removed, see below...
> Acked-by: Julian Anastasov <ja@xxxxxx>

Thanks, I have applied this with the extra space removed.
I will submit it for inclusion in v4.18.
To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at

<Prev in Thread] Current Thread [Next in Thread>