LVS
lvs-devel
Google
 
Web LinuxVirtualServer.org

Re: [PATCH v2 0/3] ipvsadm: Document/add support for fo/ovf/mh scheduler

To: Julian Anastasov <ja@xxxxxx>
Subject: Re: [PATCH v2 0/3] ipvsadm: Document/add support for fo/ovf/mh schedulers
Cc: Quentin Armitage <quentin@xxxxxxxxxxxxxxx>, Simon Horman <horms@xxxxxxxxxxxx>, lvs-devel@xxxxxxxxxxxxxxx, lvs-users@xxxxxxxxxxxxxxxxxxxxxx, Inju Song <inju.song@xxxxxxxxxxxxx>, brouer@xxxxxxxxxx
From: Jesper Dangaard Brouer <brouer@xxxxxxxxxx>
Date: Tue, 22 Jan 2019 12:02:35 +0100
On Thu, 17 Jan 2019 02:09:22 +0200 (EET) Julian Anastasov <ja@xxxxxx> wrote:

> On Wed, 16 Jan 2019, Quentin Armitage wrote:
> 
> > The kernel supports the fo, ovf and mh IPVS schedulers, but ipvsadm has not
> > yet been updated to document/support them. Currently ipvsadm can support 
> > them,
> > but users of ipvsadm will not be aware of their existence without reading 
> > the
> > kernel sources.
> > 
> > The following patches document support for these schedulers, and also adds
> > new flags mh-fallback and mh-port.
> > 
> > Changes since v1:
> > - Correct description of fo scheduler
> > - Correct description of ovf scheduler
> > - Completely rewrite description of mh scheduler
> > - Move definitions of IP_VS_SVC_F_SCHED_MH* from ipvsadm.c to 
> > libipvs/ip_vs.h
> > - Don't print flag-3 for SH and MH schedulers
> > 
> > With many thanks to Julian Anastasov for pointing out the errors in the
> > v1 patches and the suggested improvements.
> > 
> > Quentin Armitage (3):
> >   ipvsadm: Document support of fo scheduler
> >   ipvsadm: Document support of ovf scheduler
> >   ipvsadm: Add support for mh scheduler
> > 
> >  SCHEDULERS      |  2 +-
> >  ipvsadm.8       | 18 ++++++++++++++++++
> >  ipvsadm.c       | 17 +++++++++++++++--
> >  libipvs/ip_vs.h |  3 +++
> >  4 files changed, 37 insertions(+), 3 deletions(-)  
> 
>       The 3 patches look ok to me. Thanks!
> 
> Acked-by: Julian Anastasov <ja@xxxxxx>
> 
>       Jesper, you can apply them if there are no other
> suggestions/comments.

Nobody else objected, thus I've applied this patchset to git tree:
  https://git.kernel.org/pub/scm/utils/kernel/ipvsadm/ipvsadm.git/

Thank you Quentin for keeping this tool up-to-date.
-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Principal Kernel Engineer at Red Hat
  LinkedIn: http://www.linkedin.com/in/brouer

<Prev in Thread] Current Thread [Next in Thread>