![]() |
lvs-devel
|
| To: | Julian Anastasov <ja@xxxxxx> |
|---|---|
| Subject: | Re: [PATCH net v2] ipvs: Improve robustness to the ipvs sysctl |
| Cc: | <wensong@xxxxxxxxxxxx>, <horms@xxxxxxxxxxxx>, <pablo@xxxxxxxxxxxxx>, <kadlec@xxxxxxxxxxxxxxxxx>, Florian Westphal <fw@xxxxxxxxx>, <davem@xxxxxxxxxxxxx>, "netdev@xxxxxxxxxxxxxxx" <netdev@xxxxxxxxxxxxxxx>, <lvs-devel@xxxxxxxxxxxxxxx>, <netfilter-devel@xxxxxxxxxxxxxxx>, <coreteam@xxxxxxxxxxxxx>, Mingfangsen <mingfangsen@xxxxxxxxxx>, <wangxiaogang3@xxxxxxxxxx>, <xuhanbing@xxxxxxxxxx> |
| From: | hujunwei <hujunwei4@xxxxxxxxxx> |
| Date: | Wed, 31 Jul 2019 23:58:49 +0800 |
Hello, Julian
On 2019/7/31 3:29, Julian Anastasov wrote:
>
> Hello,
>
> On Tue, 30 Jul 2019, hujunwei wrote:
>
>> From: Junwei Hu <hujunwei4@xxxxxxxxxx>
>>
>> The ipvs module parse the user buffer and save it to sysctl,
>> then check if the value is valid. invalid value occurs
>> over a period of time.
>> Here, I add a variable, struct ctl_table tmp, used to read
>> the value from the user buffer, and save only when it is valid.
>> I delete proc_do_sync_mode and use extra1/2 in table for the
>> proc_dointvec_minmax call.
>>
>> Fixes: f73181c8288f ("ipvs: add support for sync threads")
>> Signed-off-by: Junwei Hu <hujunwei4@xxxxxxxxxx>
>
> Looks good to me, thanks!
>
> Acked-by: Julian Anastasov <ja@xxxxxx>
>
> BTW, why ip_vs_zero_all everywhere? Due to old git version?
>
I will update the git version and send the patch v3.
Regards,
Junwei
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH net v2] ipvs: Improve robustness to the ipvs sysctl, Julian Anastasov |
|---|---|
| Next by Date: | [PATCH net v3] ipvs: Improve robustness to the ipvs sysctl, hujunwei |
| Previous by Thread: | Re: [PATCH net v2] ipvs: Improve robustness to the ipvs sysctl, Julian Anastasov |
| Next by Thread: | [PATCH net v3] ipvs: Improve robustness to the ipvs sysctl, hujunwei |
| Indexes: | [Date] [Thread] [Top] [All Lists] |