LVS
lvs-devel
Google
 
Web LinuxVirtualServer.org

[PATCH 1/6] ipvs: no need to update skb route entry for local destinatio

To: Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>
Subject: [PATCH 1/6] ipvs: no need to update skb route entry for local destination packets.
Cc: lvs-devel@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, netfilter-devel@xxxxxxxxxxxxxxx, Wensong Zhang <wensong@xxxxxxxxxxxx>, Julian Anastasov <ja@xxxxxx>, zhang kai <zhangkaiheb@xxxxxxx>, Simon Horman <horms@xxxxxxxxxxxx>
From: Simon Horman <horms@xxxxxxxxxxxx>
Date: Tue, 15 Oct 2019 09:32:07 +0200
From: zhang kai <zhangkaiheb@xxxxxxx>

In the end of function __ip_vs_get_out_rt/__ip_vs_get_out_rt_v6,the
'local' variable is always zero.

Signed-off-by: zhang kai <zhangkaiheb@xxxxxxx>
Acked-by: Julian Anastasov <ja@xxxxxx>
Signed-off-by: Simon Horman <horms@xxxxxxxxxxxx>
---
 net/netfilter/ipvs/ip_vs_xmit.c | 18 ++++++------------
 1 file changed, 6 insertions(+), 12 deletions(-)

diff --git a/net/netfilter/ipvs/ip_vs_xmit.c b/net/netfilter/ipvs/ip_vs_xmit.c
index 888d3068a492..b1e300f8881b 100644
--- a/net/netfilter/ipvs/ip_vs_xmit.c
+++ b/net/netfilter/ipvs/ip_vs_xmit.c
@@ -407,12 +407,9 @@ __ip_vs_get_out_rt(struct netns_ipvs *ipvs, int skb_af, 
struct sk_buff *skb,
                goto err_put;
 
        skb_dst_drop(skb);
-       if (noref) {
-               if (!local)
-                       skb_dst_set_noref(skb, &rt->dst);
-               else
-                       skb_dst_set(skb, dst_clone(&rt->dst));
-       } else
+       if (noref)
+               skb_dst_set_noref(skb, &rt->dst);
+       else
                skb_dst_set(skb, &rt->dst);
 
        return local;
@@ -574,12 +571,9 @@ __ip_vs_get_out_rt_v6(struct netns_ipvs *ipvs, int skb_af, 
struct sk_buff *skb,
                goto err_put;
 
        skb_dst_drop(skb);
-       if (noref) {
-               if (!local)
-                       skb_dst_set_noref(skb, &rt->dst);
-               else
-                       skb_dst_set(skb, dst_clone(&rt->dst));
-       } else
+       if (noref)
+               skb_dst_set_noref(skb, &rt->dst);
+       else
                skb_dst_set(skb, &rt->dst);
 
        return local;
-- 
2.11.0


<Prev in Thread] Current Thread [Next in Thread>