LVS
lvs-devel
Google
 
Web LinuxVirtualServer.org

Re: 答复: [PATCH v2] ipvs: clean code for ip_vs_sync.c

To: "Zhouxudong (EulerOS)" <zhouxudong8@xxxxxxxxxx>
Subject: Re: 答复: [PATCH v2] ipvs: clean code for ip_vs_sync.c
Cc: Suraj Upadhyay <usuraj35@xxxxxxxxx>, "wensong@xxxxxxxxxxxx" <wensong@xxxxxxxxxxxx>, "horms@xxxxxxxxxxxx" <horms@xxxxxxxxxxxx>, "netdev@xxxxxxxxxxxxxxx" <netdev@xxxxxxxxxxxxxxx>, "lvs-devel@xxxxxxxxxxxxxxx" <lvs-devel@xxxxxxxxxxxxxxx>, "kernel-janitors@xxxxxxxxxxxxxxx" <kernel-janitors@xxxxxxxxxxxxxxx>, "Chenxiang (EulerOS)" <rose.chen@xxxxxxxxxx>, "Zhaowei (EulerOS)" <zhaowei23@xxxxxxxxxx>
From: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Date: Thu, 16 Jul 2020 13:23:22 +0300
It's probably better to start somewhere like drivers/staging for clean
up work.  Networking people are pretty busy with their own things but
staging is happy to take clean up patches.

You need to use a proper legal name (like you would for signing
documents for your From and Signed-off-by.

> > @@ -1444,7 +1444,7 @@ static int bind_mcastif_addr(struct socket *sock, 
> > struct net_device *dev)
> >     sin.sin_addr.s_addr  = addr;
> >     sin.sin_port         = 0;
> 
> I think you missed this one.
> should be
> -        sin.sin_port         = 0;
> +      sin.sin_port = 0

That was done deliberately.  Just leave that one as-is, please.

regards,
dan carpenter


<Prev in Thread] Current Thread [Next in Thread>