![]()  | 
 
lvs-devel
 
 | 
| To: | Jakub Kicinski <kuba@xxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>, Eric Dumazet <edumazet@xxxxxxxxxx> | 
|---|---|
| Subject: | [PATCH net-next v2 1/4] ipv6: silence compilation warning for non-IPV6 builds | 
| Cc: | Leon Romanovsky <leonro@xxxxxxxxxx>, coreteam@xxxxxxxxxxxxx, Florian Westphal <fw@xxxxxxxxx>, Hideaki YOSHIFUJI <yoshfuji@xxxxxxxxxxxxxx>, Jozsef Kadlecsik <kadlec@xxxxxxxxxxxxx>, Julian Anastasov <ja@xxxxxx>, lvs-devel@xxxxxxxxxxxxxxx, Matteo Croce <mcroce@xxxxxxxxxx>, netdev@xxxxxxxxxxxxxxx, netfilter-devel@xxxxxxxxxxxxxxx, Simon Horman <horms@xxxxxxxxxxxx> | 
| From: | Leon Romanovsky <leon@xxxxxxxxxx> | 
| Date: | Wed, 3 Feb 2021 15:51:09 +0200 | 
From: Leon Romanovsky <leonro@xxxxxxxxxx>
The W=1 compilation of allmodconfig generates the following warning:
net/ipv6/icmp.c:448:6: warning: no previous prototype for 'icmp6_send' 
[-Wmissing-prototypes]
  448 | void icmp6_send(struct sk_buff *skb, u8 type, u8 code, __u32 info,
      |      ^~~~~~~~~~
Fix it by providing function declaration for builds with ipv6 as a module.
Signed-off-by: Leon Romanovsky <leonro@xxxxxxxxxx>
---
 include/linux/icmpv6.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/icmpv6.h b/include/linux/icmpv6.h
index 1b3371ae8193..452d8978ffc7 100644
--- a/include/linux/icmpv6.h
+++ b/include/linux/icmpv6.h
@@ -16,9 +16,9 @@ static inline struct icmp6hdr *icmp6_hdr(const struct sk_buff 
*skb)
 typedef void ip6_icmp_send_t(struct sk_buff *skb, u8 type, u8 code, __u32 info,
                             const struct in6_addr *force_saddr);
-#if IS_BUILTIN(CONFIG_IPV6)
 void icmp6_send(struct sk_buff *skb, u8 type, u8 code, __u32 info,
                const struct in6_addr *force_saddr);
+#if IS_BUILTIN(CONFIG_IPV6)
 static inline void icmpv6_send(struct sk_buff *skb, u8 type, u8 code, __u32 
info)
 {
        icmp6_send(skb, type, code, info, NULL);
--
2.29.2
 | 
| <Prev in Thread] | Current Thread | [Next in Thread> | 
|---|---|---|
  | ||
| Previous by Date: | [PATCH net-next v2 4/4] netfilter: move handlers to net/ip_vs.h, Leon Romanovsky | 
|---|---|
| Next by Date: | [PATCH net-next v2 0/4] Fix W=1 compilation warnings in net/* folder, Leon Romanovsky | 
| Previous by Thread: | [PATCH net-next v2 4/4] netfilter: move handlers to net/ip_vs.h, Leon Romanovsky | 
| Next by Thread: | Re: [PATCH net-next v2 0/4] Fix W=1 compilation warnings in net/* folder, Jakub Kicinski | 
| Indexes: | [Date] [Thread] [Top] [All Lists] |