LVS
lvs-devel
Google
 
Web LinuxVirtualServer.org

Re: [RFC PATCHv5 3/6] ipvs: use kthreads for stats estimation

To: Jiri Wiesner <jwiesner@xxxxxxx>
Subject: Re: [RFC PATCHv5 3/6] ipvs: use kthreads for stats estimation
Cc: Simon Horman <horms@xxxxxxxxxxxx>, lvs-devel@xxxxxxxxxxxxxxx, yunhong-cgl jiang <xintian1976@xxxxxxxxx>, dust.li@xxxxxxxxxxxxxxxxx
From: Julian Anastasov <ja@xxxxxx>
Date: Wed, 26 Oct 2022 18:29:39 +0300 (EEST)
        Hello,

On Mon, 24 Oct 2022, Julian Anastasov wrote:

>       While finishing this posting, I'm investigating
> the idea to use structures without chains (no relinking),
> without chain_len, tick_len, etc. But let me first see
> if such idea can work...

        Hm, I tried some ideas but result is not good at all.
chain_max looks like a good implicit way to apply cond_resched
rate and to return to some safe position on return. Other methods
with arrays will (1) allocate more memory or (2) slowdown searching
for free slot while adding or (3) slowdown while walking during
estimation. Now we benefit from long chains (33/38 as in your
setup) to (1) use less memory to store ests in chains and (2) to
reduce the cost from for_each_set_bit() operation.

        So, for now I don't have any better idea to change
the data structures.

        After your feedback I can prepare next version by adding
wait_event_idle_timeout() calls as pause between tests.

Regards

--
Julian Anastasov <ja@xxxxxx>


<Prev in Thread] Current Thread [Next in Thread>