![]() |
lvs-devel
|
| To: | Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] ipvs: use explicitly signed chars |
| Cc: | Julian Anastasov <ja@xxxxxx>, Simon Horman <horms@xxxxxxxxxxxx>, stable@xxxxxxxxxxxxxxx, netfilter-devel@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, lvs-devel@xxxxxxxxxxxxxxx |
| From: | "Jason A. Donenfeld" <Jason@xxxxxxxxx> |
| Date: | Wed, 2 Nov 2022 03:44:38 +0100 |
Hi Pablo, On Wed, Oct 26, 2022 at 2:34 PM Jason A. Donenfeld <Jason@xxxxxxxxx> wrote: > > The `char` type with no explicit sign is sometimes signed and sometimes > unsigned. This code will break on platforms such as arm, where char is > unsigned. So mark it here as explicitly signed, so that the > todrop_counter decrement and subsequent comparison is correct. > > Cc: Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> > Cc: Julian Anastasov <ja@xxxxxx> > Cc: Simon Horman <horms@xxxxxxxxxxxx> > Cc: stable@xxxxxxxxxxxxxxx > Signed-off-by: Jason A. Donenfeld <Jason@xxxxxxxxx> Wondering if you planned on taking this into nf.git for 6.1? Thanks, Jason |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Next by Date: | Re: [PATCH] ipvs: use explicitly signed chars, Pablo Neira Ayuso |
|---|---|
| Next by Thread: | Re: [PATCH] ipvs: use explicitly signed chars, Pablo Neira Ayuso |
| Indexes: | [Date] [Thread] [Top] [All Lists] |