LVS
lvs-devel
Google
 
Web LinuxVirtualServer.org

Re: [PATCH] ipvs: Fix checksumming on GSO of SCTP packets

To: Julian Anastasov <ja@xxxxxx>
Subject: Re: [PATCH] ipvs: Fix checksumming on GSO of SCTP packets
Cc: linux-kernel@xxxxxxxxxxxxxxx, Firo Yang <firo.yang@xxxxxxxx>, Andreas Taschner <andreas.taschner@xxxxxxxx>, Michal Kubeček <mkubecek@xxxxxxxx>, Simon Horman <horms@xxxxxxxxxxxx>, lvs-devel@xxxxxxxxxxxxxxx, netfilter-devel@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, coreteam@xxxxxxxxxxxxx
From: Ismael Luceno <iluceno@xxxxxxx>
Date: Sun, 21 Apr 2024 16:26:59 +0200
On 21/Apr/2024 14:01, Julian Anastasov wrote:
<...>
>       Thanks for the fix, I'll accept this but skb_is_gso_sctp()
> has comment for pre-condition: skb_is_gso(skb). Can you send v2
> with it?

Thanks; sent!

>       I'm guessing what should be the Fixes line, may be?:
> 
> Fixes: 90017accff61 ("sctp: Add GSO support")

This seems like the right one.

>       because SCTP GSO was added after the IPVS code? Or the
> more recent commit d02f51cbcf12 which adds skb_is_gso_sctp ?

That doesn't seem related at all.

Do we need to check .gso_type in cases like this?


<Prev in Thread] Current Thread [Next in Thread>