LVS
lvs-devel
Google
 
Web LinuxVirtualServer.org

Re: [PATCH ipvsadm v2 0/5] Debian package fixes

To: Jeremy Sowden <azazel@xxxxxxxxxx>
Subject: Re: [PATCH ipvsadm v2 0/5] Debian package fixes
Cc: LVS Devel <lvs-devel@xxxxxxxxxxxxxxx>
From: Julian Anastasov <ja@xxxxxx>
Date: Wed, 15 Jan 2025 19:50:00 +0200 (EET)
        Hello,

On Mon, 13 Jan 2025, Jeremy Sowden wrote:

> The Debian package of ipvsadm carries a few patches.  Some of them have been
> around for years.  None of them is specific to Debian, so I'm forwarding them
> upstream.
> 
> Patch 1 bumps the maximum weight accepted by ipvsadm.
> Patch 2 fixes an unclear usage error message.
> Patches 3-5 make some improvements to the Makefiles.

        Applying the kernel rules here, the commit description
in patch 1, 2 and 5 should not exceed the maximum of 75 chars
per line:

scripts/checkpatch.pl --strict /tmp/file.patch

        Can you wrap the texts in a new v3?

> Changes since v1:
> 
> * The previous version of patch 2 changed the logic of the option parsing in
>   such a way that using `-M` after `-6` no longer worked correctly.  This 
> version 
>   just rewords the error message.
> 
> Jeremy Sowden (5):
>   ipvsadm: increase maximum weight value
>   ipvsadm: fix ambiguous usage error message
>   Use variable for pkg-config in Makefiles
>   Support environmental and command-line `*FLAGS` variable in Makefiles
>   Make sure libipvs.a is built before ipvsadm
> 
>  Makefile         | 19 +++++++++++--------
>  ipvsadm.8        |  2 +-
>  ipvsadm.c        |  4 ++--
>  libipvs/Makefile | 29 +++++++++++++++--------------
>  4 files changed, 29 insertions(+), 25 deletions(-)
> 
> -- 
> 2.45.2

Regards

--
Julian Anastasov <ja@xxxxxx>



<Prev in Thread] Current Thread [Next in Thread>