LVS
lvs-devel
Google
 
Web LinuxVirtualServer.org

Re: [PATCH RESEND] ipvs: ip_vs_conn_expire_now: Rename del_timer in comm

To: WangYuli <wangyuli@xxxxxxxxxxxxx>
Subject: Re: [PATCH RESEND] ipvs: ip_vs_conn_expire_now: Rename del_timer in comment
Cc: horms@xxxxxxxxxxxx, ja@xxxxxx, kadlec@xxxxxxxxxxxxx, davem@xxxxxxxxxxxxx, edumazet@xxxxxxxxxx, kuba@xxxxxxxxxx, pabeni@xxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, lvs-devel@xxxxxxxxxxxxxxx, netfilter-devel@xxxxxxxxxxxxxxx, coreteam@xxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, zhanjun@xxxxxxxxxxxxx, niecheng1@xxxxxxxxxxxxx, guanwentao@xxxxxxxxxxxxx, wangyuli@xxxxxxxxxx
From: Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>
Date: Tue, 22 Jul 2025 05:25:07 +0200
On Fri, Jul 04, 2025 at 04:35:53PM +0800, WangYuli wrote:
> Commit 8fa7292fee5c ("treewide: Switch/rename to timer_delete[_sync]()")
> switched del_timer to timer_delete, but did not modify the comment for
> ip_vs_conn_expire_now(). Now fix it.

$ git grep del_timer net/netfilter/
net/netfilter/ipvs/ip_vs_lblc.c: *     Julian Anastasov        :    replaced 
del_timer call with del_timer_sync
net/netfilter/ipvs/ip_vs_lblc.c: *                                   handler 
and del_timer thread in SMP

Wider search, in the net tree:

net/ipv4/igmp.c: *                                      which caused a 
"del_timer() called
net/ipv4/igmp.c: *              Christian Daudt :       removed del_timer from

Maybe these are only for historical purpose, so leaving them untouched
is fine.


<Prev in Thread] Current Thread [Next in Thread>