LVS
lvs-devel
Google
 
Web LinuxVirtualServer.org

Re: [PATCH v2 net] ipvs: Fix estimator kthreads preferred affinity

To: Julian Anastasov <ja@xxxxxx>
Subject: Re: [PATCH v2 net] ipvs: Fix estimator kthreads preferred affinity
Cc: Frederic Weisbecker <frederic@xxxxxxxxxx>, LKML <linux-kernel@xxxxxxxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, David Ahern <dsahern@xxxxxxxxxx>, Simon Horman <horms@xxxxxxxxxxxx>, Eric Dumazet <edumazet@xxxxxxxxxx>, Jakub Kicinski <kuba@xxxxxxxxxx>, Paolo Abeni <pabeni@xxxxxxxxxx>, Jozsef Kadlecsik <kadlec@xxxxxxxxxxxxx>, netdev@xxxxxxxxxxxxxxx, lvs-devel@xxxxxxxxxxxxxxx, netfilter-devel@xxxxxxxxxxxxxxx, coreteam@xxxxxxxxxxxxx
From: Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>
Date: Thu, 7 Aug 2025 15:00:49 +0200
On Wed, Jul 30, 2025 at 01:28:16PM +0300, Julian Anastasov wrote:
> 
>       Hello,
> 
> On Tue, 29 Jul 2025, Frederic Weisbecker wrote:
> 
> > The estimator kthreads' affinity are defined by sysctl overwritten
> > preferences and applied through a plain call to the scheduler's affinity
> > API.
> > 
> > However since the introduction of managed kthreads preferred affinity,
> > such a practice shortcuts the kthreads core code which eventually
> > overwrites the target to the default unbound affinity.
> > 
> > Fix this with using the appropriate kthread's API.
> > 
> > Fixes: d1a89197589c ("kthread: Default affine kthread to its preferred NUMA 
> > node")
> > Signed-off-by: Frederic Weisbecker <frederic@xxxxxxxxxx>
> 
>       Looks good to me for the nf tree, thanks!
> 
> Acked-by: Julian Anastasov <ja@xxxxxx>

For the record: Apologies, I will include this patch in the next pull request.


<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH v2 net] ipvs: Fix estimator kthreads preferred affinity, Pablo Neira Ayuso <=