LVS
lvs-devel
Google
 
Web LinuxVirtualServer.org

Re: [PATCHv2 nf 0/8] IPVS fixes for nf

To: Simon Horman <horms@xxxxxxxxxxxx>
Subject: Re: [PATCHv2 nf 0/8] IPVS fixes for nf
Cc: Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>, Florian Westphal <fw@xxxxxxxxx>, Waiman Long <longman@xxxxxxxxxx>, lvs-devel@xxxxxxxxxxxxxxx, netfilter-devel@xxxxxxxxxxxxxxx
From: Julian Anastasov <ja@xxxxxx>
Date: Thu, 30 Apr 2026 10:22:54 +0300 (EEST)
        Hello,

On Wed, 29 Apr 2026, Julian Anastasov wrote:

>         This patchset contains accumulated fixes for the nf tree:
> 
> 1-3) Fixes for the recently added resizable hash tables (v5)
> 
> 4) dest from trash can be leaked if ip_vs_start_estimator() fails
> 
> 5) fixed races and locking for the estimation kthreads (v5)
> 
> 6) fix for wrong roundup_pow_of_two() usage in the resizable hash
>    tables
> 
> 7-8) v2 of the changes from Waiman Long to properly guard against
>   the housekeeping_cpumask() updates:
> 
>   
> https://lore.kernel.org/netfilter-devel/20260331165015.2777765-1-longman@xxxxxxxxxx/
> 
>   I added missing Fixes tag. The original description:
> 
>   Since commit 041ee6f3727a ("kthread: Rely on HK_TYPE_DOMAIN for preferred
>   affinity management"), the HK_TYPE_KTHREAD housekeeping cpumask may no
>   longer be correct in showing the actual CPU affinity of kthreads that
>   have no predefined CPU affinity. As the ipvs networking code is still
>   using HK_TYPE_KTHREAD, we need to make HK_TYPE_KTHREAD reflect the
>   reality.
> 
>   This patch series makes HK_TYPE_KTHREAD an alias of HK_TYPE_DOMAIN
>   and uses RCU to protect access to the HK_TYPE_KTHREAD housekeeping
>   cpumask.
> 
> v2:
> * Reports: https://sashiko.dev/#/patchset/20260428175725.72050-1-ja%40ssi.bg
> * introduce new patch at position 4 (dest leak)
> * patch 6: check for n > 1 before roundup_pow_of_two
> * patch 7 and 8 are now in reverse order to help bisection
> 
> Julian Anastasov (6):
>   ipvs: fixes for the new ip_vs_status info
>   ipvs: fix races around the conn_lfactor and svc_lfactor sysctl vars
>   ipvs: fix the spin_lock usage for RT build
>   ipvs: do not leak dest after get from dest trash
>   ipvs: fix races around est_mutex and est_cpulist
>   ipvs: fix shift-out-of-bounds in ip_vs_rht_desired_size
> 
> Waiman Long (2):
>   ipvs: Guard access of HK_TYPE_KTHREAD cpumask with RCU
>   sched/isolation: Make HK_TYPE_KTHREAD an alias of HK_TYPE_DOMAIN
> 
>  include/linux/sched/isolation.h |   6 +-
>  include/net/ip_vs.h             |  31 +++++-
>  net/netfilter/ipvs/ip_vs_conn.c |  76 ++++++++-------
>  net/netfilter/ipvs/ip_vs_core.c |   2 +-
>  net/netfilter/ipvs/ip_vs_ctl.c  | 164 +++++++++++++++++++++++---------
>  net/netfilter/ipvs/ip_vs_est.c  |  83 +++++++++-------
>  6 files changed, 241 insertions(+), 121 deletions(-)
> 
> -- 
> 2.53.0

        Will send v3 after rebase...
        
pw-bot: changes-requested

Regards

--
Julian Anastasov <ja@xxxxxx>



<Prev in Thread] Current Thread [Next in Thread>