Re: [PATCH] (3/6) ipvs -- use list_for_each_entry macro's

["Jacob Coby" <jcoby@xxxxxxxxxxxxxxx>]

>   /* decrease the module use count */
> @@ -239,13 +235,11 @@
>   */
>  struct ip_vs_app *ip_vs_app_get_by_name(char *appname)
>  {
> - struct list_head *p;
>   struct ip_vs_app *app, *a = NULL;
>
>   down(&__ip_vs_app_mutex);
>
> - list_for_each (p, &ip_vs_app_list) {
> - app = list_entry(p, struct ip_vs_app, a_list);
> + list_for_each_entry(ent, &ip_vs_app_list, a_list) {
>   if (strcmp(app->name, appname))
>   continue;

Am I missing something here, or has 'ent' not been defined?  I think it is
supposed to be:

+ list_for_each_entry(app, &ip_vs_app_list, a_list) {

-Jacob
Listingbook.com