|
Morning Horms, Wensong (if you're already awake)
>> http://www.drugphish.ch/patches/ratz/LVS/ipvsadm-1.24-exact-1.diff
>
> Sorry that this is a bit noisy, I've included the whole patch for
> the record. Annotations inline.
Thanks for your review, mate.
> Please keep in mind that Wensong still handles ipvsadm releases,
> so my comments are only my opinions.
Ok, dearest Wensong, pengyou, shoushi :). It's already 3 people that
would really love this tiny piece of software addition to be included
into the ipvsadm tool. Would you be willing to include it?
>> +#define OPT_SORT 0x040000
>> +#define OPT_SYNCID 0x080000
>> +#define OPT_EXACT 0x100000
>> +#define NUMBER_OF_OPT 21
>
> Padding each value out an extra 2 bytes is a bit noisy,
> but as the result is cleaner than it otherwise would be,
> and its a one off hit for the next 8 options, I guess its ok.
Good.
>> +/*ZERO*/ {'x', 'x', ' ', 'x', 'x', 'x', 'x', 'x', 'x', 'x', 'x', 'x',
>> 'x',
>> 'x', 'x', 'x', 'x', 'x', 'x', 'x', 'x'},
>> };
>
> That noise is unavoidable without restructuring :(
How I hate this part above; every time I enhance IPVS with something I
have to touch this thing. Eventually my screen size will not suffice
anymore to enhance this :).
>> @@ -1401,10 +1416,10 @@
>> MINIMUM_IPVS_VERSION_MINOR,
>> MINIMUM_IPVS_VERSION_PATCH)) {
>> fprintf(stderr,
>> - "Warning: IPVS version missmatch: \n"
>> + "Warning: IPVS version mismatch: \n"
>> " Kernel compiled with IPVS version %d.%d.%d\n"
>> " ipvsadm " IPVSADM_VERSION_NO
>> - " requires minimum IPVS version %d.%d.%d\n\n",
>> + " requires minimum IPVS version %d.%d.%d\n\n",
>> NVERSION(ipvs_info.version),
>> MINIMUM_IPVS_VERSION_MAJOR,
>> MINIMUM_IPVS_VERSION_MINOR,
>> @@ -1554,6 +1569,16 @@
>> }
>
> The fragment above seems to be undelated to the exact pattern match,
> can you remove it?
Sure, I can. However I do think the spelling fix should go in. I'll
update this for the next round.
Regards,
Roberto Nibali, ratz
--
echo
'[q]sa[ln0=aln256%Pln256/snlbx]sb3135071790101768542287578439snlbxq' | dc
|
