|
Hello to everyone,
thanks for really fast response to this topic.
> Is it really needed to have a timer in case OPS is active? Or would it
> be even more effort to comment the timer code out for OPS-flagged
> packets, than just leaving it in.
>
> > > /* reset it expire in its timeout */
> > > mod_timer(&cp->timer, jiffies+cp->timeout);
> > >
> > > @@ -506,7 +514,7 @@
> > > /*
> > > * unhash it if it is hashed in the conn table
> > > */
> > > - if (!ip_vs_conn_unhash(cp))
> > > + if (!ip_vs_conn_unhash(cp) && !(cp->flags &
> IP_VS_CONN_F_ONE_PACKET))
> > > goto expire_later;
> > >
> > > /*
I'm far from expertise for LVS codebase. But while playing with OPS I've
encountered odd behavior on bigger load I've notice increased memory
consumption. I have added some logging to code and it seemed to me that
function [void ip_vs_conn_expire_now(struct ip_vs_conn *cp)] doesn't do
it's job. It is possible that I've miss-interpreted something.
So in my opinion it would be much better to avoid timer creation and
connection hashing. Actually it is not needed in this case. Of course if
it doesn't ruin complete concept.
Best regards,
Viktor
|
