|
Jaro,
I've thought about the verbage and do agree with you. However, I wanted to
keep the change to a minimal because some organization out there may already
be monitoring the logs for the existing strings. That's why I choosed to
change the string for the lesser critical of the two messages. I opted to
retain the exact string for the failure/restore due to status checks since
these are unplanned events. I was hoping that this patch could be applied
with minimal changes to organizational practices/procedures.
-Dung
On 1/12/07, jarol1@xxxxxxxxx <J.Libak@xxxxxxxxxx> wrote:
Dung Nguyen wrote:
> Per request, I've made the following modification to the patch.
>
> On configuration file reload event:
> delete : "Purged real server: ..."
> restore: "Re-added real server: ..."
>
> On status check:
> delete : "Deleted real server: ..."
> restore: "Added real server: ..."
>
> So for monitoring service, one would want to monitor these strings:
> "Deleted real server" and "Added real server".
>
I think Re-added would make more sense for status check and Added for
reload.
Or another way of dealing with this problem would be mentioning "status
check" and "reload" in the log. Then we could have only "added" and
"deleted". The same fix should be made for the email subject that is
sent to the admin by ldirectord.
It could look like this:
On status check:
delete : "Deleted real server due to status check failure"
restore: "Added real server due to status check success"
On configuration file reload event:
delete : "Deleted real server due to reload event"
restore: "Added real server due to reload event"
Either way, Horms is the maintainer of ldirectord so we have to find a
solution that he will accept. In my opinion the 2nd solution is better
as it clearly states why a server was added or deleted.
Jaro
_______________________________________________
LinuxVirtualServer.org mailing list - lvs-users@xxxxxxxxxxxxxxxxxxxxxx
Send requests to lvs-users-request@xxxxxxxxxxxxxxxxxxxxxx
or go to http://www.in-addr.de/mailman/listinfo/lvs-users
|
