LVS
lvs-users
Google
 
Web LinuxVirtualServer.org

Re: [PATCH v2 0/3] ipvsadm: Document/add support for fo/ovf/mh scheduler

To: Quentin Armitage <quentin@xxxxxxxxxxxxxxx>
Subject: Re: [PATCH v2 0/3] ipvsadm: Document/add support for fo/ovf/mh schedulers
Cc: Jesper Dangaard Brouer <brouer@xxxxxxxxxx>, Simon Horman <horms@xxxxxxxxxxxx>, lvs-devel@xxxxxxxxxxxxxxx, lvs-users@xxxxxxxxxxxxxxxxxxxxxx, Inju Song <inju.song@xxxxxxxxxxxxx>
From: Julian Anastasov <ja@xxxxxx>
Date: Thu, 17 Jan 2019 02:09:22 +0200 (EET)
        Hello,

On Wed, 16 Jan 2019, Quentin Armitage wrote:

> The kernel supports the fo, ovf and mh IPVS schedulers, but ipvsadm has not
> yet been updated to document/support them. Currently ipvsadm can support them,
> but users of ipvsadm will not be aware of their existence without reading the
> kernel sources.
> 
> The following patches document support for these schedulers, and also adds
> new flags mh-fallback and mh-port.
> 
> Changes since v1:
> - Correct description of fo scheduler
> - Correct description of ovf scheduler
> - Completely rewrite description of mh scheduler
> - Move definitions of IP_VS_SVC_F_SCHED_MH* from ipvsadm.c to libipvs/ip_vs.h
> - Don't print flag-3 for SH and MH schedulers
> 
> With many thanks to Julian Anastasov for pointing out the errors in the
> v1 patches and the suggested improvements.
> 
> Quentin Armitage (3):
>   ipvsadm: Document support of fo scheduler
>   ipvsadm: Document support of ovf scheduler
>   ipvsadm: Add support for mh scheduler
> 
>  SCHEDULERS      |  2 +-
>  ipvsadm.8       | 18 ++++++++++++++++++
>  ipvsadm.c       | 17 +++++++++++++++--
>  libipvs/ip_vs.h |  3 +++
>  4 files changed, 37 insertions(+), 3 deletions(-)

        The 3 patches look ok to me. Thanks!

Acked-by: Julian Anastasov <ja@xxxxxx>

        Jesper, you can apply them if there are no other
suggestions/comments.

Regards

--
Julian Anastasov <ja@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>