LVS
lvs-devel
Google
 
Web LinuxVirtualServer.org

Re: [PATCHv2 2/2] IPVS: Add genetlink interface implementation

To: "Thomas Graf" <tgraf@xxxxxxx>
Subject: Re: [PATCHv2 2/2] IPVS: Add genetlink interface implementation
Cc: netdev@xxxxxxxxxxxxxxx, lvs-devel@xxxxxxxxxxxxxxx, horms@xxxxxxxxxxxx, kaber@xxxxxxxxx, davem@xxxxxxxxxxxxx, vbusam@xxxxxxxxxx
From: "Julius Volz" <juliusv@xxxxxxxxxx>
Date: Sat, 26 Jul 2008 00:39:10 +0200
On Fri, Jul 25, 2008 at 1:58 AM, Thomas Graf <tgraf@xxxxxxx> wrote:
> * Julius Volz <juliusv@xxxxxxxxxx> 2008-07-21 15:02
>> +static int ip_vs_genl_parse_dest(struct ip_vs_dest_user *udest,
>> +                              struct nlattr *nla, int full_entry)
>> +{
>> +     struct nlattr *attrs[IPVS_SVC_ATTR_MAX + 1];
>> +     struct nlattr *nla_addr, *nla_port;
>> +
>> +     /* Parse mandatory identifying destination fields first */
>> +     if (nla == NULL ||
>> +         nla_parse_nested(attrs, IPVS_DEST_ATTR_MAX, nla, 
>> ip_vs_dest_policy))
>
> Small typo here, attrs[] is defined with a length of IPVS_SVC_ATTR_MAX+1
> while IPVS_DEST_ATTR_MAX is passed to to nla_parse_nested.

Right, thanks for catching this! Will include this in the next
iteration after vacation...

Julius

-- 
Google Switzerland GmbH
--
To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

<Prev in Thread] Current Thread [Next in Thread>