LVS
lvs-devel
Google
 
Web LinuxVirtualServer.org

[PATCH 09/17] ipvs: remove check for IP_VS_CONN_F_SYNC from ip_vs_bind_d

To: Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>
Subject: [PATCH 09/17] ipvs: remove check for IP_VS_CONN_F_SYNC from ip_vs_bind_dest
Cc: lvs-devel@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, netfilter-devel@xxxxxxxxxxxxxxx, Wensong Zhang <wensong@xxxxxxxxxxxx>, Julian Anastasov <ja@xxxxxx>, Hans Schillstrom <hans.schillstrom@xxxxxxxxxxxx>, Jesper Dangaard Brouer <brouer@xxxxxxxxxx>, Simon Horman <horms@xxxxxxxxxxxx>
From: Simon Horman <horms@xxxxxxxxxxxx>
Date: Wed, 2 May 2012 10:24:53 +0900
From: Julian Anastasov <ja@xxxxxx>

        As the IP_VS_CONN_F_INACTIVE bit is properly set
in cp->flags for all kind of connections we do not need to
add special checks for synced connections when updating
the activeconns/inactconns counters for first time. Now
logic will look just like in ip_vs_unbind_dest.

Signed-off-by: Julian Anastasov <ja@xxxxxx>
Signed-off-by: Simon Horman <horms@xxxxxxxxxxxx>
---
 net/netfilter/ipvs/ip_vs_conn.c |    9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/net/netfilter/ipvs/ip_vs_conn.c b/net/netfilter/ipvs/ip_vs_conn.c
index f562e63..7647f3b 100644
--- a/net/netfilter/ipvs/ip_vs_conn.c
+++ b/net/netfilter/ipvs/ip_vs_conn.c
@@ -585,11 +585,10 @@ ip_vs_bind_dest(struct ip_vs_conn *cp, struct ip_vs_dest 
*dest)
 
        /* Update the connection counters */
        if (!(cp->flags & IP_VS_CONN_F_TEMPLATE)) {
-               /* It is a normal connection, so increase the inactive
-                  connection counter because it is in TCP SYNRECV
-                  state (inactive) or other protocol inacive state */
-               if ((cp->flags & IP_VS_CONN_F_SYNC) &&
-                   (!(cp->flags & IP_VS_CONN_F_INACTIVE)))
+               /* It is a normal connection, so modify the counters
+                * according to the flags, later the protocol can
+                * update them on state change */
+               if (!(cp->flags & IP_VS_CONN_F_INACTIVE))
                        atomic_inc(&dest->activeconns);
                else
                        atomic_inc(&dest->inactconns);
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

<Prev in Thread] Current Thread [Next in Thread>