Re: [PATCH 3/5] net/netfilter/ipvs/ip_vs_ctl.c: drop argument range chec

lvs-devel

Re: [PATCH 3/5] net/netfilter/ipvs/ip_vs_ctl.c: drop argument range chec

To:	Julian Anastasov <ja@xxxxxx>
Subject:	Re: [PATCH 3/5] net/netfilter/ipvs/ip_vs_ctl.c: drop argument range check just before the check for equality
Cc:	"linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, kernel-janitors@xxxxxxxxxxxxxxx, coreteam@xxxxxxxxxxxxx, netfilter-devel@xxxxxxxxxxxxxxx, lvs-devel@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, dcb314@xxxxxxxxxxx, David Miller <davem@xxxxxxxxxxxxx>, kadlec@xxxxxxxxxxxxxxxxx, Patrick McHardy <kaber@xxxxxxxxx>, pablo@xxxxxxxxxxxxx, Simon Horman <horms@xxxxxxxxxxxx>, wensong@xxxxxxxxxxxx
From:	Andrey Utkin <andrey.krieger.utkin@xxxxxxxxx>
Date:	Sat, 19 Jul 2014 00:06:28 +0300

2014-07-18 23:48 GMT+03:00 Julian Anastasov <ja@xxxxxx>:
>         The above check ensures the set_arglen[] value (some
> struct size) does not exceed the arg[MAX_ARG_LEN] space. You can check
> commit 04bcef2a83f40c ("ipvs: Add boundary check on ioctl arguments")
> for more info.

Thanks for info.
What about static check at compilation time?

#if (DAEMON_ARG_LEN > MAX_ARG_LEN) \
 || (SERVICE_ARG_LEN > MAX_ARG_LEN) \
 || (SVCDEST_ARG_LEN > MAX_ARG_LEN)
#error MAX_ARG_LEN exceeded in set_arglen table
#endif

-- 
Andrey Utkin
--
To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 3/5] net/netfilter/ipvs/ip_vs_ctl.c: drop argument range check just before the check for equality, Andrey Utkin Re: [PATCH 3/5] net/netfilter/ipvs/ip_vs_ctl.c: drop argument range check just before the check for equality, Julian Anastasov Re: [PATCH 3/5] net/netfilter/ipvs/ip_vs_ctl.c: drop argument range check just before the check for equality, Andrey Utkin <= Re: [PATCH 3/5] net/netfilter/ipvs/ip_vs_ctl.c: drop argument range check just before the check for equality, Andrey Utkin Re: [PATCH 3/5] net/netfilter/ipvs/ip_vs_ctl.c: drop argument range check just before the check for equality, Andrey Utkin Re: [PATCH 3/5] net/netfilter/ipvs/ip_vs_ctl.c: drop argument range check just before the check for equality, Julian Anastasov Re: [PATCH 3/5] net/netfilter/ipvs/ip_vs_ctl.c: drop argument range check just before the check for equality, Dan Carpenter Re: [PATCH 3/5] net/netfilter/ipvs/ip_vs_ctl.c: drop argument range check just before the check for equality, Julian Anastasov Re: [PATCH 3/5] net/netfilter/ipvs/ip_vs_ctl.c: drop argument range check just before the check for equality, Dan Carpenter

Previous by Date:	Re: [PATCH 3/5] net/netfilter/ipvs/ip_vs_ctl.c: drop argument range check just before the check for equality, Julian Anastasov
Next by Date:	Re: [PATCH 3/5] net/netfilter/ipvs/ip_vs_ctl.c: drop argument range check just before the check for equality, Andrey Utkin
Previous by Thread:	Re: [PATCH 3/5] net/netfilter/ipvs/ip_vs_ctl.c: drop argument range check just before the check for equality, Julian Anastasov
Next by Thread:	Re: [PATCH 3/5] net/netfilter/ipvs/ip_vs_ctl.c: drop argument range check just before the check for equality, Andrey Utkin
Indexes:	[Date] [Thread] [Top] [All Lists]