LVS
lvs-devel
Google
 
Web LinuxVirtualServer.org

Re: [PATCH] libipvs: discrepancy with libnl genlmsg_put

To: Jesper Dangaard Brouer <brouer@xxxxxxxxxx>
Subject: Re: [PATCH] libipvs: discrepancy with libnl genlmsg_put
Cc: lvs-devel@xxxxxxxxxxxxxxx, Julian Anastasov <ja@xxxxxx>, Simon Horman <horms@xxxxxxxxxxxx>
From: Arthur Gautier <baloo@xxxxxxxxx>
Date: Thu, 5 Oct 2017 17:20:04 +0000
On Thu, Oct 05, 2017 at 12:03:33PM +0200, Jesper Dangaard Brouer wrote:
> On Wed, 27 Sep 2017 15:31:05 +0000
> baloo@xxxxxxxxx wrote:
> 
> > From: Arthur Gautier <baloo@xxxxxxxxx>
> > 
> > There is a mixup between NL_AUTO_PORT and NL_AUTO_PID. The
> > first should be used with genlmsg_put while the second with
> > nlmsg_put.
> > 
> > This is not a problem, because both NL_AUTO_PORT and NL_AUTO_PID
> > have the same value, but still a discrepancy with libnl documentation.
> > 
> > see documentation of genlmsg_put here:
> >   
> > http://www.infradead.org/~tgr/libnl/doc/api/group__genl.html#ga9a86a71bbba6961d41b8a75f62f9e946
> > 
> > Cc: Julian Anastasov <ja@xxxxxx>
> > Cc: Simon Horman <horms@xxxxxxxxxxxx>
> > Cc: Jesper Dangaard Brouer <brouer@xxxxxxxxxx>
> > Signed-off-by: Arthur Gautier <baloo@xxxxxxxxx>
> > ---
> 
> Applied this here:
>  
> https://git.kernel.org/pub/scm/utils/kernel/ipvsadm/ipvsadm.git/commit/?id=76c12701481
> 
> Thank you Arthur for bringing this discrepancy in-order :-)

My OCD says thank you.

-- 
\o/ Arthur
 G  Gandi.net
--
To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

<Prev in Thread] Current Thread [Next in Thread>