LVS
lvs-devel
Google
 
Web LinuxVirtualServer.org

Re: [PATCH nf] ipvs: correctly print the memory size of ip_vs_conn_tab

To: Pengcheng Yang <yangpc@xxxxxxxxxx>
Subject: Re: [PATCH nf] ipvs: correctly print the memory size of ip_vs_conn_tab
Cc: Julian Anastasov <ja@xxxxxx>, lvs-devel@xxxxxxxxxxxxxxx, Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>, Jozsef Kadlecsik <kadlec@xxxxxxxxxxxxx>, Florian Westphal <fw@xxxxxxxxx>, netfilter-devel@xxxxxxxxxxxxxxx
From: Simon Horman <horms@xxxxxxxxxxxx>
Date: Fri, 15 Apr 2022 09:21:47 +0200
On Tue, Apr 12, 2022 at 05:00:31PM +0800, Pengcheng Yang wrote:
> The memory size of ip_vs_conn_tab changed after we use hlist
> instead of list.
> 
> Fixes: 731109e78415 ("ipvs: use hlist instead of list")
> Signed-off-by: Pengcheng Yang <yangpc@xxxxxxxxxx>

Acked-by: Simon Horman <horms@xxxxxxxxxxxx>

> ---
>  net/netfilter/ipvs/ip_vs_conn.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/netfilter/ipvs/ip_vs_conn.c b/net/netfilter/ipvs/ip_vs_conn.c
> index 2c467c4..e886c74 100644
> --- a/net/netfilter/ipvs/ip_vs_conn.c
> +++ b/net/netfilter/ipvs/ip_vs_conn.c
> @@ -1495,7 +1495,7 @@ int __init ip_vs_conn_init(void)
>       pr_info("Connection hash table configured "
>               "(size=%d, memory=%ldKbytes)\n",
>               ip_vs_conn_tab_size,
> -             (long)(ip_vs_conn_tab_size*sizeof(struct list_head))/1024);
> +             (long)(ip_vs_conn_tab_size*sizeof(struct hlist_head))/1024);
>       IP_VS_DBG(0, "Each connection entry needs %zd bytes at least\n",
>                 sizeof(struct ip_vs_conn));
>  
> -- 
> 1.8.3.1
> 

<Prev in Thread] Current Thread [Next in Thread>