LVS
lvs-devel
Google
 
Web LinuxVirtualServer.org

[PATCH RFC net-next 11/14] ipvs: no_cport and dropentry counters can be

To: Simon Horman <horms@xxxxxxxxxxxx>
Subject: [PATCH RFC net-next 11/14] ipvs: no_cport and dropentry counters can be per-net
Cc: lvs-devel@xxxxxxxxxxxxxxx, netfilter-devel@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, "Paul E . McKenney" <paulmck@xxxxxxxxxx>, rcu@xxxxxxxxxxxxxxx, Dust Li <dust.li@xxxxxxxxxxxxxxxxx>, Jiejian Wu <jiejian@xxxxxxxxxxxxxxxxx>, Jiri Wiesner <jwiesner@xxxxxxx>
From: Julian Anastasov <ja@xxxxxx>
Date: Tue, 15 Aug 2023 20:30:28 +0300
With using per-net conn_tab these counters do not need to be
global anymore.

Signed-off-by: Julian Anastasov <ja@xxxxxx>
---
 include/net/ip_vs.h             |  2 ++
 net/netfilter/ipvs/ip_vs_conn.c | 59 +++++++++++++++++++--------------
 2 files changed, 37 insertions(+), 24 deletions(-)

diff --git a/include/net/ip_vs.h b/include/net/ip_vs.h
index f5605c289bba..ed74e4e36f21 100644
--- a/include/net/ip_vs.h
+++ b/include/net/ip_vs.h
@@ -1158,6 +1158,7 @@ struct netns_ipvs {
 #endif
        /* ip_vs_conn */
        atomic_t                conn_count;      /* connection counter */
+       atomic_t                no_cport_conns[IP_VS_AF_MAX];
        struct delayed_work     conn_resize_work;/* resize conn_tab */
 
        /* ip_vs_ctl */
@@ -1188,6 +1189,7 @@ struct netns_ipvs {
        int                     drop_counter;
        int                     old_secure_tcp;
        atomic_t                dropentry;
+       s8                      dropentry_counters[8];
        /* locks in ctl.c */
        spinlock_t              dropentry_lock;  /* drop entry handling */
        spinlock_t              droppacket_lock; /* drop packet handling */
diff --git a/net/netfilter/ipvs/ip_vs_conn.c b/net/netfilter/ipvs/ip_vs_conn.c
index f9111bfefd81..80858d9c69ac 100644
--- a/net/netfilter/ipvs/ip_vs_conn.c
+++ b/net/netfilter/ipvs/ip_vs_conn.c
@@ -53,9 +53,6 @@ int ip_vs_conn_tab_size __read_mostly;
 /*  SLAB cache for IPVS connections */
 static struct kmem_cache *ip_vs_conn_cachep __read_mostly;
 
-/*  counter for no client port connections */
-static atomic_t ip_vs_conn_no_cport_cnt = ATOMIC_INIT(0);
-
 /* We need an addrstrlen that works with or without v6 */
 #ifdef CONFIG_IP_VS_IPV6
 #define IP_VS_ADDRSTRLEN INET6_ADDRSTRLEN
@@ -318,10 +315,16 @@ struct ip_vs_conn *ip_vs_conn_in_get(const struct 
ip_vs_conn_param *p)
        struct ip_vs_conn *cp;
 
        cp = __ip_vs_conn_in_get(p);
-       if (!cp && atomic_read(&ip_vs_conn_no_cport_cnt)) {
-               struct ip_vs_conn_param cport_zero_p = *p;
-               cport_zero_p.cport = 0;
-               cp = __ip_vs_conn_in_get(&cport_zero_p);
+       if (!cp) {
+               struct netns_ipvs *ipvs = p->ipvs;
+               int af_id = ip_vs_af_index(p->af);
+
+               if (atomic_read(&ipvs->no_cport_conns[af_id])) {
+                       struct ip_vs_conn_param cport_zero_p = *p;
+
+                       cport_zero_p.cport = 0;
+                       cp = __ip_vs_conn_in_get(&cport_zero_p);
+               }
        }
 
        IP_VS_DBG_BUF(9, "lookup/in %s %s:%d->%s:%d %s\n",
@@ -534,6 +537,7 @@ void ip_vs_conn_fill_cport(struct ip_vs_conn *cp, __be16 
cport)
 {
        struct hlist_bl_head *head, *head2, *head_new;
        struct netns_ipvs *ipvs = cp->ipvs;
+       int af_id = ip_vs_af_index(cp->af);
        u32 hash_r = 0, hash_key_r = 0;
        struct ip_vs_rht *t, *tp, *t2;
        u32 hash_key, hash_key_new;
@@ -612,7 +616,7 @@ void ip_vs_conn_fill_cport(struct ip_vs_conn *cp, __be16 
cport)
                        hlist_bl_del_rcu(&cp->c_list);
                        hlist_bl_add_head_rcu(&cp->c_list, head_new);
                }
-               atomic_dec(&ip_vs_conn_no_cport_cnt);
+               atomic_dec(&ipvs->no_cport_conns[af_id]);
                cp->flags &= ~IP_VS_CONN_F_NO_CPORT;
                cp->cport = cport;
        }
@@ -1177,8 +1181,11 @@ static void ip_vs_conn_expire(struct timer_list *t)
                if (unlikely(cp->app != NULL))
                        ip_vs_unbind_app(cp);
                ip_vs_unbind_dest(cp);
-               if (cp->flags & IP_VS_CONN_F_NO_CPORT)
-                       atomic_dec(&ip_vs_conn_no_cport_cnt);
+               if (unlikely(cp->flags & IP_VS_CONN_F_NO_CPORT)) {
+                       int af_id = ip_vs_af_index(cp->af);
+
+                       atomic_dec(&ipvs->no_cport_conns[af_id]);
+               }
                if (cp->flags & IP_VS_CONN_F_ONE_PACKET)
                        ip_vs_conn_rcu_free(&cp->rcu_head);
                else
@@ -1285,8 +1292,11 @@ ip_vs_conn_new(const struct ip_vs_conn_param *p, int 
dest_af,
        cp->out_seq.delta = 0;
 
        atomic_inc(&ipvs->conn_count);
-       if (flags & IP_VS_CONN_F_NO_CPORT)
-               atomic_inc(&ip_vs_conn_no_cport_cnt);
+       if (unlikely(flags & IP_VS_CONN_F_NO_CPORT)) {
+               int af_id = ip_vs_af_index(cp->af);
+
+               atomic_inc(&ipvs->no_cport_conns[af_id]);
+       }
 
        /* Bind the connection with a destination server */
        cp->dest = NULL;
@@ -1571,12 +1581,7 @@ static const struct seq_operations 
ip_vs_conn_sync_seq_ops = {
  */
 static inline int todrop_entry(struct ip_vs_conn *cp)
 {
-       /*
-        * The drop rate array needs tuning for real environments.
-        * Called from timer bh only => no locking
-        */
-       static const signed char todrop_rate[9] = {0, 1, 2, 3, 4, 5, 6, 7, 8};
-       static signed char todrop_counter[9] = {0};
+       struct netns_ipvs *ipvs = cp->ipvs;
        int i;
 
        /* if the conn entry hasn't lasted for 60 seconds, don't drop it.
@@ -1585,15 +1590,17 @@ static inline int todrop_entry(struct ip_vs_conn *cp)
        if (time_before(cp->timeout + jiffies, cp->timer.expires + 60*HZ))
                return 0;
 
-       /* Don't drop the entry if its number of incoming packets is not
-          located in [0, 8] */
+       /* Drop only conns with number of incoming packets in [1..8] range */
        i = atomic_read(&cp->in_pkts);
-       if (i > 8 || i < 0) return 0;
+       if (i > 8 || i < 1)
+               return 0;
 
-       if (!todrop_rate[i]) return 0;
-       if (--todrop_counter[i] > 0) return 0;
+       i--;
+       if (--ipvs->dropentry_counters[i] > 0)
+               return 0;
 
-       todrop_counter[i] = todrop_rate[i];
+       /* Prefer to drop conns with less number of incoming packets */
+       ipvs->dropentry_counters[i] = i + 1;
        return 1;
 }
 
@@ -1811,7 +1818,11 @@ void ip_vs_expire_nodest_conn_flush(struct netns_ipvs 
*ipvs)
  */
 int __net_init ip_vs_conn_net_init(struct netns_ipvs *ipvs)
 {
+       int idx;
+
        atomic_set(&ipvs->conn_count, 0);
+       for (idx = 0; idx < IP_VS_AF_MAX; idx++)
+               atomic_set(&ipvs->no_cport_conns[idx], 0);
        INIT_DELAYED_WORK(&ipvs->conn_resize_work, conn_resize_work_handler);
        RCU_INIT_POINTER(ipvs->conn_tab, NULL);
        atomic_set(&ipvs->conn_tab_changes, 0);
-- 
2.41.0



<Prev in Thread] Current Thread [Next in Thread>