LVS
lvs-devel
Google
 
Web LinuxVirtualServer.org

Re: [PATCH net-next v6 3/8] net: rds: Remove the now superfluous sentine

To: "kadlec@xxxxxxxxxxxxx" <kadlec@xxxxxxxxxxxxx>, "dsahern@xxxxxxxxxx" <dsahern@xxxxxxxxxx>, "tonylu@xxxxxxxxxxxxxxxxx" <tonylu@xxxxxxxxxxxxxxxxx>, "mcgrof@xxxxxxxxxx" <mcgrof@xxxxxxxxxx>, "fw@xxxxxxxxx" <fw@xxxxxxxxx>, "davem@xxxxxxxxxxxxx" <davem@xxxxxxxxxxxxx>, "matttbe@xxxxxxxxxx" <matttbe@xxxxxxxxxx>, "anna@xxxxxxxxxx" <anna@xxxxxxxxxx>, "trond.myklebust@xxxxxxxxxxxxxxx" <trond.myklebust@xxxxxxxxxxxxxxx>, "tom@xxxxxxxxxx" <tom@xxxxxxxxxx>, "pabeni@xxxxxxxxxx" <pabeni@xxxxxxxxxx>, "ms@xxxxxxxxxx" <ms@xxxxxxxxxx>, "stefan@xxxxxxxxxxxxxxxxxx" <stefan@xxxxxxxxxxxxxxxxxx>, "lucien.xin@xxxxxxxxx" <lucien.xin@xxxxxxxxx>, "ying.xue@xxxxxxxxxxxxx" <ying.xue@xxxxxxxxxxxxx>, "steffen.klassert@xxxxxxxxxxx" <steffen.klassert@xxxxxxxxxxx>, "marc.dionne@xxxxxxxxxxxx" <marc.dionne@xxxxxxxxxxxx>, "herbert@xxxxxxxxxxxxxxxxxxx" <herbert@xxxxxxxxxxxxxxxxxxx>, "geliang@xxxxxxxxxx" <geliang@xxxxxxxxxx>, "ralf@xxxxxxxxxxxxxx" <ralf@xxxxxxxxxxxxxx>, "dhowells@xxxxxxxxxx" <dhowells@xxxxxxxxxx>, "kuba@xxxxxxxxxx" <kuba@xxxxxxxxxx>, Dai Ngo <dai.ngo@xxxxxxxxxx>, "jmaloy@xxxxxxxxxx" <jmaloy@xxxxxxxxxx>, "alex.aring@xxxxxxxxx" <alex.aring@xxxxxxxxx>, "ja@xxxxxx" <ja@xxxxxx>, "pablo@xxxxxxxxxxxxx" <pablo@xxxxxxxxxxxxx>, "horms@xxxxxxxxxxxx" <horms@xxxxxxxxxxxx>, "j.granados@xxxxxxxxxxx" <j.granados@xxxxxxxxxxx>, "kolga@xxxxxxxxxx" <kolga@xxxxxxxxxx>, "courmisch@xxxxxxxxx" <courmisch@xxxxxxxxx>, "keescook@xxxxxxxxxxxx" <keescook@xxxxxxxxxxxx>, "martineau@xxxxxxxxxx" <martineau@xxxxxxxxxx>, "roopa@xxxxxxxxxx" <roopa@xxxxxxxxxx>, "wenjia@xxxxxxxxxxxxx" <wenjia@xxxxxxxxxxxxx>, "edumazet@xxxxxxxxxx" <edumazet@xxxxxxxxxx>, "razor@xxxxxxxxxxxxx" <razor@xxxxxxxxxxxxx>, "jaka@xxxxxxxxxxxxx" <jaka@xxxxxxxxxxxxx>, "jreuter@xxxxxxxx" <jreuter@xxxxxxxx>, "guwen@xxxxxxxxxxxxxxxxx" <guwen@xxxxxxxxxxxxxxxxx>, "miquel.raynal@xxxxxxxxxxx" <miquel.raynal@xxxxxxxxxxx>, "jlayton@xxxxxxxxxx" <jlayton@xxxxxxxxxx>, "marcelo.leitner@xxxxxxxxx" <marcelo.leitner@xxxxxxxxx>, Chuck Lever III <chuck.lever@xxxxxxxxxx>, "neilb@xxxxxxx" <neilb@xxxxxxx>, "alibuda@xxxxxxxxxxxxxxxxx" <alibuda@xxxxxxxxxxxxxxxxx>
Subject: Re: [PATCH net-next v6 3/8] net: rds: Remove the now superfluous sentinel elements from ctl_table array
Cc: "tipc-discussion@xxxxxxxxxxxxxxxxxxxxx" <tipc-discussion@xxxxxxxxxxxxxxxxxxxxx>, "bridge@xxxxxxxxxxxxxxx" <bridge@xxxxxxxxxxxxxxx>, "rds-devel@xxxxxxxxxxxxxx" <rds-devel@xxxxxxxxxxxxxx>, "netfilter-devel@xxxxxxxxxxxxxxx" <netfilter-devel@xxxxxxxxxxxxxxx>, "linux-sctp@xxxxxxxxxxxxxxx" <linux-sctp@xxxxxxxxxxxxxxx>, "dccp@xxxxxxxxxxxxxxx" <dccp@xxxxxxxxxxxxxxx>, "coreteam@xxxxxxxxxxxxx" <coreteam@xxxxxxxxxxxxx>, "linux-hams@xxxxxxxxxxxxxxx" <linux-hams@xxxxxxxxxxxxxxx>, "linux-s390@xxxxxxxxxxxxxxx" <linux-s390@xxxxxxxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, "linux-rdma@xxxxxxxxxxxxxxx" <linux-rdma@xxxxxxxxxxxxxxx>, "linux-x25@xxxxxxxxxxxxxxx" <linux-x25@xxxxxxxxxxxxxxx>, "lvs-devel@xxxxxxxxxxxxxxx" <lvs-devel@xxxxxxxxxxxxxxx>, "linux-nfs@xxxxxxxxxxxxxxx" <linux-nfs@xxxxxxxxxxxxxxx>, "linux-afs@xxxxxxxxxxxxxxxxxxx" <linux-afs@xxxxxxxxxxxxxxxxxxx>, "netdev@xxxxxxxxxxxxxxx" <netdev@xxxxxxxxxxxxxxx>, "linux-wpan@xxxxxxxxxxxxxxx" <linux-wpan@xxxxxxxxxxxxxxx>, "mptcp@xxxxxxxxxxxxxxx" <mptcp@xxxxxxxxxxxxxxx>
From: Allison Henderson <allison.henderson@xxxxxxxxxx>
Date: Fri, 3 May 2024 02:27:22 +0000
On Wed, 2024-05-01 at 11:29 +0200, Joel Granados via B4 Relay wrote:
> From: Joel Granados <j.granados@xxxxxxxxxxx>
> 
> This commit comes at the tail end of a greater effort to remove the
> empty elements at the end of the ctl_table arrays (sentinels) which
> will reduce the overall build time size of the kernel and run time
> memory bloat by ~64 bytes per sentinel (further information Link :
> https://lore.kernel.org/all/ZO5Yx5JFogGi%2FcBo@xxxxxxxxxxxxxxxxxxxxxx/
> )
> 
> * Remove sentinel element from ctl_table structs.
> 
> Signed-off-by: Joel Granados <j.granados@xxxxxxxxxxx>
These changes look fine to me.  Thank you!
Acked-by: Allison Henderson <allison.henderson@xxxxxxxxxx>

> ---
>  net/rds/ib_sysctl.c | 1 -
>  net/rds/sysctl.c    | 1 -
>  net/rds/tcp.c       | 1 -
>  3 files changed, 3 deletions(-)
> 
> diff --git a/net/rds/ib_sysctl.c b/net/rds/ib_sysctl.c
> index e4e41b3afce7..2af678e71e3c 100644
> --- a/net/rds/ib_sysctl.c
> +++ b/net/rds/ib_sysctl.c
> @@ -103,7 +103,6 @@ static struct ctl_table rds_ib_sysctl_table[] = {
>                 .mode           = 0644,
>                 .proc_handler   = proc_dointvec,
>         },
> -       { }
>  };
>  
>  void rds_ib_sysctl_exit(void)
> diff --git a/net/rds/sysctl.c b/net/rds/sysctl.c
> index e381bbcd9cc1..025f518a4349 100644
> --- a/net/rds/sysctl.c
> +++ b/net/rds/sysctl.c
> @@ -89,7 +89,6 @@ static struct ctl_table rds_sysctl_rds_table[] = {
>                 .mode           = 0644,
>                 .proc_handler   = proc_dointvec,
>         },
> -       { }
>  };
>  
>  void rds_sysctl_exit(void)
> diff --git a/net/rds/tcp.c b/net/rds/tcp.c
> index 2dba7505b414..d8111ac83bb6 100644
> --- a/net/rds/tcp.c
> +++ b/net/rds/tcp.c
> @@ -86,7 +86,6 @@ static struct ctl_table rds_tcp_sysctl_table[] = {
>                 .proc_handler   = rds_tcp_skbuf_handler,
>                 .extra1         = &rds_tcp_min_rcvbuf,
>         },
> -       { }
>  };
>  
>  u32 rds_tcp_write_seq(struct rds_tcp_connection *tc)
> 

<Prev in Thread] Current Thread [Next in Thread>