LVS
lvs-users
Google
 
Web LinuxVirtualServer.org

Re: ipvs patch for kernel 2.4.4

To: lvs-users@xxxxxxxxxxxxxxxxxxxxxx
Subject: Re: ipvs patch for kernel 2.4.4
From: Horms <horms@xxxxxxxxxxxx>
Date: Sat, 28 Apr 2001 16:52:18 -0700
On Sat, Apr 28, 2001 at 10:21:32PM +0200, Alois Treindl wrote:
> On Sat, 28 Apr 2001, Horms wrote:
> 
> > On Sat, Apr 28, 2001 at 09:37:08PM +0200, Alois Treindl wrote:
> > > 
> > > How do I patch kernel 2.4.4 for ipvs?
> > > Can I apply the 2.4.3 patchfile?
> > 
> > The kernel patch for 2.4.x is very small. You should be able to appy
> > the 2.4.3 patch to 2.4.4 without any trouble.
> > 
> 
> tried, does not work:
> ip_vs_conn.c: In function `ip_vs_tunnel_xmit':
> ip_vs_conn.c:982: too few arguments to function `ip_select_ident' 
> 
> In kernel 2.4.4, the function ip_select_ident() has 3 arguments,
> while in previous kernels it had only two.
> 
> It is defined as:
> include/net/ip.h:static inline void ip_select_ident(struct iphdr *iph,
> struct dst_entry *dst, struct sock *sk)
> 
> There is also 
> include/net/ip.h:extern void __ip_select_ident(struct iphdr *iph, struct
> dst_entry *dst); 
> 
> It corresponds to the previous definition of ip_select_ident().
> 
> It seems that in ipvs-0.2.11 there is only one change
> required:
> 
> ip_vs_conn.ca:983:   ip_select_ident(iph, &rt->u.dst); 
> to
> ip_vs_conn.c:983:   __ip_select_ident(iph, &rt->u.dst);
> 
> Now kernel 2.4.4 compiled.
> Whether it runs I cannot test during the weekend because my director box
> is at the office, while I am at home, and I do not dare rebooting a new
> kernel from remote, because I can't do anything if the boot hangs.

I believe that your solution may run into problems if packets
are marked don't fragment.

If the last argument to the 2.4.4 version of ip_select_ident() is
NULL then it is ignored. With reference to ipip.c in the 2.4.4 kernel
this is the desired behaviour.

-- 
Horms
 horms@xxxxxxxxxxxx 
 http://vergenet.net/~horms/

Attachment: ipvs-0.2.11_kernel-2.4.4.patch
Description: Text document

<Prev in Thread] Current Thread [Next in Thread>