|
Hello,
On Tue, 23 Sep 2003, Rusty Russell wrote:
> > better the following stuff to be included now. Rusty, Dave? Is
> > someone willing to review this before inclusion?
>
> Sure...
>
> > http://www.ssi.bg/~ja/ipvs-2.6.0-test2/readme.txt
>
> > - at least struct iphdr in first fragment, not shared
> >
> > - ip_defrag is already called, so ip_send_check is still needed
> >
> > - then we add all needed checks for read and write access and extending
> > the first fragment
>
> Alexey's advice was not to pull packets we don't modify, but use
> skb_copy_bits, and use skb_ip_make_writable() where we do modify.
> This means that you don't have to care about shared or cloned skbs, it
> makes your intentions explicit, and it's more future-proof.
>
> It's more invasive, but my experience with doing netfilter_ipv4 was
> that it made things much neater when finished. It helps to get rid of
> lots of the temporary variables, too, I've found (too easy to forget
> to update them).
Ok, thank you Rusty! We will need some time to check the
changes...
Regards
--
Julian Anastasov <ja@xxxxxx>
|
