LVS
lvs-devel
Google
 
Web LinuxVirtualServer.org

Re: [PATCH RFC 08/24] IPVS: Make protocol handler functions support IPv6

To: Julius Volz <juliusv@xxxxxxxxxx>
Subject: Re: [PATCH RFC 08/24] IPVS: Make protocol handler functions support IPv6
Cc: netdev@xxxxxxxxxxxxxxx, lvs-devel@xxxxxxxxxxxxxxx, horms@xxxxxxxxxxxx, kaber@xxxxxxxxx, vbusam@xxxxxxxxxx
From: Brian Haley <brian.haley@xxxxxx>
Date: Thu, 21 Aug 2008 11:12:12 -0400
Julius Volz wrote:
Still, I think my original interpretation was correct? It's always
used with constant values and there are many usages similar to this:

skb->protocol = __constant_htons(ETH_P_802_3);

Someone feel free to correct me.

I know it's a minor point, but look at tcp_ipv6.c:

        if (skb->protocol == htons(ETH_P_IP))
                return tcp_v4_conn_request(sk, skb);

That's different from the code you quoted that's doing an assignment. __constant_htons() isn't used anywhere in an if() statement, although I did find a couple in the bonding driver that should be fixed.

-Brian
--
To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

<Prev in Thread] Current Thread [Next in Thread>