Re: [PATCH v2 2/2] IPVS: use pr_err and friends instead of IP_VS_ERR and friends

[Simon Horman <horms@xxxxxxxxxxxx>]

On Tue, Jul 28, 2009 at 01:56:55PM -0700, Joe Perches wrote:
> On Tue, 2009-07-28 at 22:35 +0200, Hannes Eder wrote:
> > Since pr_err and friends is used instead of printk there is not point
> > in keeping IP_VS_ERR and friends.
> > +                   pr_err("Schedule: port zero only supported "
> > +                          "in persistent services, "
> > +                          "check your ipvs configuration\n");
> 
> You might consider ignoring the checkpatch 80 char limit here
> and consolidate the message into a single string.

Personally, I prefer it the way it is.

> It helps when grepping.
> 
> > @@ -377,8 +377,8 @@ static int ip_vs_svc_hash(struct ip_vs_service *svc)
> >  static int ip_vs_svc_unhash(struct ip_vs_service *svc)
> >  {
> >     if (!(svc->flags & IP_VS_SVC_F_HASHED)) {
> > -           IP_VS_ERR("ip_vs_svc_unhash(): request for unhash flagged, "
> > -                     "called from %p\n", __builtin_return_address(0));
> > +           pr_err("ip_vs_svc_unhash(): request for unhash flagged, "
> > +                  "called from %p\n", __builtin_return_address(0));
> 
> Maybe use something like:
>       "%s(): <foo> called from %pf",
>        __func__, __builtin_return_address(0)
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html