Re: [patch][enhancement] ldirectord: IPv6: new directives: virtual6, real6, fallback6

[Sohgo Takeuchi <sohgo@xxxxxxxxxxxxxxxx>]

From: Sohgo Takeuchi <sohgo@xxxxxxxxxxxxxxxx>
|
> From: Sohgo Takeuchi <sohgo@xxxxxxxxxxxxxxxx>
> |
>> Hi simon,
>> 
>> From: Simon Horman <horms@xxxxxxxxxxxx>
>> |
>>> Hi Takeuchi-san,
>>> 
>>> On Wed, Aug 04, 2010 at 12:13:24AM +0900, Sohgo Takeuchi wrote:
>>>> 
>>>> Hi simon,
>>>> 
>>>> From: Simon Horman <horms@xxxxxxxxxxxx>
>>>> |
>>>> > On Mon, Aug 02, 2010 at 06:35:49PM +0900, Sohgo Takeuchi wrote:
>>>> >>     [Candidate 3] Completely separate IPv4 and IPv6 using
>>>> >>         "hoge6" keywords.
>>>> >>     
>>>> >>     Adding new keywords which denote IPv6. These keywords can
>>>> >>     handle IPv6 only and have a name "hoge6".
>>>> >> 
>>>> >>         fallback=fallback.example.com
>>>> >>         fallback6=fallback.example.com
>>>> >>         virtual=virtual.example.com:daytime
>>>> >>             real=real1.example.com:daytime gate
>>>> >>             real=10.10.10.10:daytime gate
>>>> >>         
>>>> >>         virtual6=virtual.example.com:daytime
>>>> >>             real6=real1.example.com:daytime gate
>>>> >>             real6=[2001:db8::10]:daytime gate
>>>> >>             fallback6=localhost:daytime
>>>> >> 
>>>> >>     This way is very similar to [Candidate 2]. But it is
>>>> >>     consistent and easy to read. A demerit is a bit redundant?
>>>> > 
>>>> > I like candidate 3. Yes, it is redundant, but it is also very clear
>>>> > and consistent.
>>>> 
>>>> Yes.
>>>> 
>>>> I have implemented [candidate 3]. Now it works good.
>>> 
>>> Great, once you've finished your testing please post the patch.
>> 
>> Sure!
> 
> I attached a patch to enhance an IPv6 support of ldirectord.
> 
> - Added new directives: virtual6, real6, fallback6.
>   These are used to specify IPv6 as addresses or hostnames.
>   Now cannot specify an IPv6 address in a "virtual" and "real"
>   line (This breaks backwards compatibility).
> - Supported following checktypes and services.
>   checktype: connect, external, external-perl, negotiate, off,
>              on, checktimeoutN
>   service: dns, nntp, none, simpletcp, sip
> - firewall-mark + IPv6 works.

Any comments and any refinement of my code are appreciated.

Thank you.

--
Sohgo Takeuchi
--
To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html