Re: [patch v2 03/12] [PATCH 03/12] IPVS: compact ip_vs_sched

lvs-devel

Re: [patch v2 03/12] [PATCH 03/12] IPVS: compact ip_vs_sched_persist()

To:	Simon Horman <horms@xxxxxxxxxxxx>
Subject:	Re: [patch v2 03/12] [PATCH 03/12] IPVS: compact ip_vs_sched_persist()
Cc:	lvs-devel@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, netfilter@xxxxxxxxxxxxxxx, netfilter-devel@xxxxxxxxxxxxxxx, Jan Engelhardt <jengelh@xxxxxxxxxx>, Stephen Hemminger <shemminger@xxxxxxxxxx>, Wensong Zhang <wensong@xxxxxxxxxxxx>, Patrick McHardy <kaber@xxxxxxxxx>
From:	Julian Anastasov <ja@xxxxxx>
Date:	Sat, 2 Oct 2010 10:56:19 +0300 (EEST)


        Hello,

On Sat, 2 Oct 2010, Simon Horman wrote:

        Here dport:

+       dport = dest->port;


        should be:

        dport = ports[1];
        if (dport == svc->port && dest->port)
                dport = dest->port;


Thanks, fixed.


        I'm still wondering, may be it needs separate patch
but we do not support NAT to different dest->port in the
case for fwmark. May be the above logic can be changed to
support it. By this way web to different VIPs and VPORTs
in a single virtual service (fwmark) can use single NAT
real server for name-based virtual hosting. But such change
can create compatibility problems for setups that used
different vports for the fwmark service and still expect
it in that way (vport to same dport).

Regards

--
Julian Anastasov <ja@xxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[patch v2 00/12] IPVS: SIP Persistence Engine, Simon Horman [patch v2 01/12] [PATCH 01/12] netfilter: nf_conntrack_sip: Allow ct_sip_get_header() to be called with a null ct argument, Simon Horman [patch v2 02/12] [PATCH 02/12] netfilter: nf_conntrack_sip: Add callid parser, Simon Horman [patch v2 03/12] [PATCH 03/12] IPVS: compact ip_vs_sched_persist(), Simon Horman Re: [patch v2 03/12] [PATCH 03/12] IPVS: compact ip_vs_sched_persist(), Julian Anastasov Re: [patch v2 03/12] [PATCH 03/12] IPVS: compact ip_vs_sched_persist(), Simon Horman Re: [patch v2 03/12] [PATCH 03/12] IPVS: compact ip_vs_sched_persist(), Julian Anastasov <= Re: [patch v2 03/12] [PATCH 03/12] IPVS: compact ip_vs_sched_persist(), Simon Horman Re: [patch v2 03/12] [PATCH 03/12] IPVS: compact ip_vs_sched_persist(), Julian Anastasov [patch v2 04/12] [PATCH 04/12] IPVS: Add struct ip_vs_conn_param, Simon Horman Re: [patch v2 04/12] [PATCH 04/12] IPVS: Add struct ip_vs_conn_param, Julian Anastasov Re: [patch v2 04/12] [PATCH 04/12] IPVS: Add struct ip_vs_conn_param, Simon Horman Re: [patch v2 04/12] [PATCH 04/12] IPVS: Add struct ip_vs_conn_param, Simon Horman [patch v2 05/12] [PATCH 05/12] IPVS: Allow null argument to ip_vs_scheduler_put(), Simon Horman [patch v2 06/12] [PATCH 06/12] IPVS: ip_vs_{un,}bind_scheduler NULL arguments, Simon Horman [patch v2 07/12] [PATCH 07/12] IPVS: Add struct ip_vs_pe, Simon Horman Re: [patch v2 07/12] [PATCH 07/12] IPVS: Add struct ip_vs_pe, Julian Anastasov

Previous by Date:	[patch v3 12/12] IPVS: sip persistence engine, Simon Horman
Next by Date:	Re: [patch v2 03/12] [PATCH 03/12] IPVS: compact ip_vs_sched_persist(), Simon Horman
Previous by Thread:	Re: [patch v2 03/12] [PATCH 03/12] IPVS: compact ip_vs_sched_persist(), Simon Horman
Next by Thread:	Re: [patch v2 03/12] [PATCH 03/12] IPVS: compact ip_vs_sched_persist(), Simon Horman
Indexes:	[Date] [Thread] [Top] [All Lists]