lvs-devel
|
To: | paulmck@xxxxxxxxxxxxxxxxxx |
---|---|
Subject: | Re: [PATCH 2/2] ipvs: Use cond_resched_rcu_lock() helper when dumping connections |
Cc: | Peter Zijlstra <peterz@xxxxxxxxxxxxx>, Simon Horman <horms@xxxxxxxxxxxx>, Julian Anastasov <ja@xxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, lvs-devel@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, netfilter-devel@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>, Dipankar Sarma <dipankar@xxxxxxxxxx>, dhaval.giani@xxxxxxxxx |
From: | Eric Dumazet <eric.dumazet@xxxxxxxxx> |
Date: | Fri, 26 Apr 2013 11:26:55 -0700 |
On Fri, 2013-04-26 at 10:48 -0700, Paul E. McKenney wrote: > Don't get me wrong, I am not opposing cond_resched_rcu_lock() because it > will be difficult to validate. For one thing, until there are a lot of > them, manual inspection is quite possible. So feel free to apply my > Acked-by to the patch. One question : If some thread(s) is(are) calling rcu_barrier() and waiting we exit from rcu_read_lock() section, is need_resched() enough for allowing to break the section ? If not, maybe we should not test need_resched() at all. rcu_read_unlock(); cond_resched(); rcu_read_lock(); -- To unsubscribe from this list: send the line "unsubscribe lvs-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html |
Previous by Date: | Re: [PATCH 2/2] ipvs: Use cond_resched_rcu_lock() helper when dumping connections, Paul E. McKenney |
---|---|
Next by Date: | Re: [PATCH 2/2] ipvs: Use cond_resched_rcu_lock() helper when dumping connections, Paul E. McKenney |
Previous by Thread: | Re: [PATCH 2/2] ipvs: Use cond_resched_rcu_lock() helper when dumping connections, Paul E. McKenney |
Next by Thread: | Re: [PATCH 2/2] ipvs: Use cond_resched_rcu_lock() helper when dumping connections, Paul E. McKenney |
Indexes: | [Date] [Thread] [Top] [All Lists] |