lvs-devel
|
To: | Julian Anastasov <ja@xxxxxx> |
---|---|
Subject: | Re: [PATCH v2 1/2] sched: Add cond_resched_rcu_lock() helper |
Cc: | Simon Horman <horms@xxxxxxxxxxxx>, Eric Dumazet <eric.dumazet@xxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, "Paul E. McKenney" <paulmck@xxxxxxxxxxxxxxxxxx>, lvs-devel@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, netfilter-devel@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>, Dipankar Sarma <dipankar@xxxxxxxxxx> |
From: | Peter Zijlstra <peterz@xxxxxxxxxxxxx> |
Date: | Thu, 2 May 2013 09:26:24 +0200 |
On Wed, May 01, 2013 at 09:22:08PM +0300, Julian Anastasov wrote: > > +extern int __cond_resched_rcu(void); > > + > > +#define cond_resched_rcu() ({ \ > > + __might_sleep(__FILE__, __LINE__, 0); \ > > I see your goal. But digging into __might_sleep() > I see that rcu_sleep_check() will scream for the non-preempt > case because we are under rcu_read_lock. #ifdef CONFIG_PREEMPT_RCU #define PREEMPT_RCU_OFFSET 0 #else #define PREEMPT_RCU_OFFSET 1 #endif #define cond_resched_rcu() ({ \ __might_sleep(__FILE__, __LINE__, PREEMPT_RCU_OFFSET); \ __cond_resched_rcu(); \ }) Should work I think.. -- To unsubscribe from this list: send the line "unsubscribe lvs-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html |
Previous by Date: | Re: [PATCH v2 1/2] sched: Add cond_resched_rcu_lock() helper, Paul E. McKenney |
---|---|
Next by Date: | Re: [PATCH v2 1/2] sched: Add cond_resched_rcu_lock() helper, Peter Zijlstra |
Previous by Thread: | Re: [PATCH v2 1/2] sched: Add cond_resched_rcu_lock() helper, Paul E. McKenney |
Next by Thread: | Re: [PATCH v2 1/2] sched: Add cond_resched_rcu_lock() helper, Julian Anastasov |
Indexes: | [Date] [Thread] [Top] [All Lists] |