LVS
lvs-devel
Google
 
Web LinuxVirtualServer.org

Re: [PATCH 1/2] libipvs: Remove redundant CHECK_PE

To: Julian Anastasov <ja@xxxxxx>
Subject: Re: [PATCH 1/2] libipvs: Remove redundant CHECK_PE
Cc: Ryan O'Hara <rohara@xxxxxxxxxx>, lvs-devel@xxxxxxxxxxxxxxx
From: Simon Horman <horms@xxxxxxxxxxxx>
Date: Thu, 22 Aug 2013 14:04:56 +0900
On Tue, Aug 20, 2013 at 05:54:09PM +0300, Julian Anastasov wrote:
> 
>       Hello,
> 
> On Tue, 20 Aug 2013, Ryan O'Hara wrote:
> 
> > Since the CHECK_COMPAT_SVC macro calls CHECK_PE, remove the extra
> > CHECK_PE call from ipvs_get_service().
> > 
> > Signed-off-by: Ryan O'Hara <rohara@xxxxxxxxxx>
> 
>       Thanks, looks good,
> 
> Acked-by: Julian Anastasov <ja@xxxxxx>

Thanks, applied.

> 
> > ---
> >  libipvs/libipvs.c | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/libipvs/libipvs.c b/libipvs/libipvs.c
> > index ef242db..309ccce 100644
> > --- a/libipvs/libipvs.c
> > +++ b/libipvs/libipvs.c
> > @@ -965,7 +965,6 @@ ipvs_get_service_err2:
> >  #endif
> >  
> >     CHECK_COMPAT_SVC(svc, NULL);
> > -   CHECK_PE(svc, NULL);
> >     if (getsockopt(sockfd, IPPROTO_IP, IP_VS_SO_GET_SERVICE,
> >                    (char *)svc, &len)) {
> >             free(svc);
> > -- 
> > 1.8.1.4
> 
> Regards
> 
> --
> Julian Anastasov <ja@xxxxxx>
> 
--
To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

<Prev in Thread] Current Thread [Next in Thread>