LVS
lvs-devel
Google
 
Web LinuxVirtualServer.org

Re: [PATCH 2/2] libipvs: CHECK_IPV4 and CHECK_PE macros should not call

To: Julian Anastasov <ja@xxxxxx>
Subject: Re: [PATCH 2/2] libipvs: CHECK_IPV4 and CHECK_PE macros should not call return
Cc: Ryan O'Hara <rohara@xxxxxxxxxx>, lvs-devel@xxxxxxxxxxxxxxx
From: Simon Horman <horms@xxxxxxxxxxxx>
Date: Thu, 22 Aug 2013 14:06:16 +0900
On Tue, Aug 20, 2013 at 05:57:33PM +0300, Julian Anastasov wrote:
> 
>       Hello,
> 
> On Tue, 20 Aug 2013, Ryan O'Hara wrote:
> 
> > The CHECK_IPV4 and CHECK_PE macros will call return if a conditional
> > is true. This is a problem for any caller that has allocated memory
> > and needs to do cleanup before returning. This patch replaces the
> > return in both macros with a goto statement. As a result, each caller
> > needs a out_err label.
> > 
> > Signed-off-by: Ryan O'Hara <rohara@xxxxxxxxxx>
> 
>       Thanks for fixing this problem!
> 
> Acked-by: Julian Anastasov <ja@xxxxxx>

Thanks, applied.
--
To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

<Prev in Thread] Current Thread [Next in Thread>