On Tue, Oct 15, 2013 at 07:40:59PM -0700, Eric Dumazet wrote:
> On Wed, 2013-10-16 at 11:13 +0900, Simon Horman wrote:
>
> > That does seem very promising but while implementing it
> > I hit a problem.
> >
> > struct tcp_skb_cb includes a field of type struct inet6_skb_parm. And
> > expanding struct inet6_skb_parm by 16 bytes means that struct tcp_skb_cb is
> > now larger than 48 bytes and no longer fits in skb->cb.
> >
> > Is it appropriate to grow skb->cb as the comment above struct tcp_skb_cb
> > suggests?
>
> Ah well...
>
> No, its not appropriate to grow sk_buff by 16 bytes, sorry.
>
> You could not change struct inet6_skb_parm, but define IP6CB as
> a compound
>
> struct ip6cb {
> struct inet6_skb_parm foo;
> struct in6_addr bar;
> };
Thanks for your guidance, that possibility had occured to me too.
I'll rework the patch accordingly.
--
To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
|