[PATCH 3/5] net/netfilter/ipvs/ip_vs_ctl.c: drop argument range check ju

To: linux-kernel@xxxxxxxxxxxxxxx, kernel-janitors@xxxxxxxxxxxxxxx, coreteam@xxxxxxxxxxxxx, netfilter-devel@xxxxxxxxxxxxxxx, lvs-devel@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx
Subject: [PATCH 3/5] net/netfilter/ipvs/ip_vs_ctl.c: drop argument range check just before the check for equality
Cc: dcb314@xxxxxxxxxxx, davem@xxxxxxxxxxxxx, kadlec@xxxxxxxxxxxxxxxxx, kaber@xxxxxxxxx, pablo@xxxxxxxxxxxxx, ja@xxxxxx, horms@xxxxxxxxxxxx, wensong@xxxxxxxxxxxx, Andrey Utkin <andrey.krieger.utkin@xxxxxxxxx>
From: Andrey Utkin <andrey.krieger.utkin@xxxxxxxxx>
Date: Fri, 18 Jul 2014 18:33:58 +0300
Reported-by: David Binderman <dcb314@xxxxxxxxxxx>
Signed-off-by: Andrey Utkin <andrey.krieger.utkin@xxxxxxxxx>
 net/netfilter/ipvs/ip_vs_ctl.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/net/netfilter/ipvs/ip_vs_ctl.c b/net/netfilter/ipvs/ip_vs_ctl.c
index 581a658..4ed7b59 100644
--- a/net/netfilter/ipvs/ip_vs_ctl.c
+++ b/net/netfilter/ipvs/ip_vs_ctl.c
@@ -2338,8 +2338,6 @@ do_ip_vs_set_ctl(struct sock *sk, int cmd, void __user 
*user, unsigned int len)
        if (cmd < IP_VS_BASE_CTL || cmd > IP_VS_SO_SET_MAX)
                return -EINVAL;
-       if (len < 0 || len >  MAX_ARG_LEN)
-               return -EINVAL;
        if (len != set_arglen[SET_CMDID(cmd)]) {
                pr_err("set_ctl: len %u != %u\n",
                       len, set_arglen[SET_CMDID(cmd)]);

To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at

<Prev in Thread] Current Thread [Next in Thread>