Re: [PATCH 3/5] net/netfilter/ipvs/ip_vs_ctl.c: drop argument range chec

To: Julian Anastasov <ja@xxxxxx>
Subject: Re: [PATCH 3/5] net/netfilter/ipvs/ip_vs_ctl.c: drop argument range check just before the check for equality
Cc: Andrey Utkin <andrey.krieger.utkin@xxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, kernel-janitors@xxxxxxxxxxxxxxx, coreteam@xxxxxxxxxxxxx, netfilter-devel@xxxxxxxxxxxxxxx, lvs-devel@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, dcb314@xxxxxxxxxxx, David Miller <davem@xxxxxxxxxxxxx>, kadlec@xxxxxxxxxxxxxxxxx, Patrick McHardy <kaber@xxxxxxxxx>, pablo@xxxxxxxxxxxxx, Simon Horman <horms@xxxxxxxxxxxx>, wensong@xxxxxxxxxxxx
From: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Date: Tue, 22 Jul 2014 12:14:41 +0300
On Tue, Jul 22, 2014 at 11:52:02AM +0300, Julian Anastasov wrote:
> > > - if (copylen > 128)
> > > + if (*len < (int) copylen || *len < 0) {
> > > +         pr_err("get_ctl: len %d < %u\n", *len, copylen);
> > 
> > Don't let users flood dmesg.  Just return an error.  (This can be
> > triggered by non-root as well).
>       For now both set and get are privileged operations,
> so we can keep it, it can catch if something wrong happens
> with the structure sizes.

If you have namespaces enabled then it's not *that* privaleged.

dan carpenter

To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at

<Prev in Thread] Current Thread [Next in Thread>