LVS
lvs-devel
Google
 
Web LinuxVirtualServer.org

Re: ipvs: Pull out crosses_local_route_boundary logic

To: Julian Anastasov <ja@xxxxxx>, Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Subject: Re: ipvs: Pull out crosses_local_route_boundary logic
Cc: <lvs-devel@xxxxxxxxxxxxxxx>
From: Alex Gartrell <agartrell@xxxxxx>
Date: Sun, 5 Oct 2014 16:47:02 -0700
Hey everyone,

On 10/1/14 12:37 PM, Julian Anastasov wrote:
    312                         *ret_saddr = saddr;
    313         }
    314 
    315         local = (rt->rt_flags & RTCF_LOCAL) ? 1 : 0;
    316         if (unlikely(crosses_local_route_boundary(skb_af, skb, rt_mode,
    317                                                   local))) {
    318                 IP_VS_DBG_RL("We are crossing local and non-local 
addresses"
    319                              " daddr=%pI4\n", &dest->addr.ip);
                                                        ^^^^^^^^^^^^^

        Good catch. In fact, I requested Alex to print
daddr in this case but then we both missed this dest here...
Alex, both v4 (&daddr) and v6 (daddr) should be fixed.

It doesn't appear to me that there's been a patch for this yet. I'll write one and send it out right away. Please LMK if there's anyone else I should send it to.

Thanks,
--
Alex Gartrell <agartrell@xxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

<Prev in Thread] Current Thread [Next in Thread>