Re: [PATCH net-next] ipvs: Avoid null-pointer deref in debug code

To: Julian Anastasov <ja@xxxxxx>
Subject: Re: [PATCH net-next] ipvs: Avoid null-pointer deref in debug code
Cc: <horms@xxxxxxxxxxxx>, <dan.carpenter@xxxxxxxxxx>, <lvs-devel@xxxxxxxxxxxxxxx>, <netdev@xxxxxxxxxxxxxxx>, <kernel-team@xxxxxx>
From: Alex Gartrell <agartrell@xxxxxx>
Date: Mon, 6 Oct 2014 08:56:40 -0700
Hey Julian,

On 10/05/2014 11:49 PM, Julian Anastasov wrote:

        You have to print the "daddr" variable as
it was done before your patchset in the
"Stopping traffic to %s address, dest: %p..." message
because dest is not present in all cases, for example,
for *bypass_xmit. Other places provide cp->daddr but
for backup server some conns can live without cp->dest.

I've sent an updated patch that does this but I have some questions about other stuff that I find mildly confusing. Specifically I didn't realize until looking at the call sites that !dest || daddr = dest->addr.ip (but maybe I'm wrong?)

If that's the case, why do we have the following line in __ip_vs_get_out_rt?

                daddr = dest->addr.ip;

If that's /always/ true then we should add the following line or a comment to the same effect to clarify

        BUG_ON(dest && dest->addr.ip != daddr);

If that's not intended to always be true, then should the patch be the following?

        ...%pI4", dest ? &dest->addr.ip : &daddr);

Alex Gartrell <agartrell@xxxxxx>
To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at

<Prev in Thread] Current Thread [Next in Thread>