Re: [PATCH 1/2] netfilter: ipvs: avoid unused variable warnings

To: Julian Anastasov <ja@xxxxxx>
Subject: Re: [PATCH 1/2] netfilter: ipvs: avoid unused variable warnings
Cc: Arnd Bergmann <arnd@xxxxxxxx>, Wensong Zhang <wensong@xxxxxxxxxxxx>, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>, Patrick McHardy <kaber@xxxxxxxxx>, Jozsef Kadlecsik <kadlec@xxxxxxxxxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, netdev@xxxxxxxxxxxxxxx, lvs-devel@xxxxxxxxxxxxxxx, netfilter-devel@xxxxxxxxxxxxxxx, coreteam@xxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
From: Simon Horman <horms@xxxxxxxxxxxx>
Date: Thu, 28 Jan 2016 08:39:53 +0900
On Wed, Jan 27, 2016 at 10:01:42PM +0200, Julian Anastasov wrote:
>       Hello,
> On Wed, 27 Jan 2016, Arnd Bergmann wrote:
> > The proc_create() and remove_proc_entry() functions do not reference
> > their arguments when CONFIG_PROC_FS is disabled, so we get a couple
> > of warnings about unused variables in IPVS:
> > 
> > ipvs/ip_vs_app.c:608:14: warning: unused variable 'net' [-Wunused-variable]
> > ipvs/ip_vs_ctl.c:3950:14: warning: unused variable 'net' [-Wunused-variable]
> > ipvs/ip_vs_ctl.c:3994:14: warning: unused variable 'net' [-Wunused-variable]
> > 
> > This removes the local variables and instead looks them up separately
> > for each use, which obviously avoids the warning.
> > 
> > Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> > Fixes: 4c50a8ce2b63 ("netfilter: ipvs: avoid unused variable warning")
>       Looks like your previous patch for ip_vs_app_net_cleanup
> was delayed in ipvs-next tree. I guess, Simon should drop it and
> use this one instead when net-next opens:
> Acked-by: Julian Anastasov <ja@xxxxxx>

Thanks, and sorry about not pushing the other patch to net-next.
I have dropped it and queued up this one in its place.
To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at

<Prev in Thread] Current Thread [Next in Thread>