LVS
lvs-devel
Google
 
Web LinuxVirtualServer.org

Re: [PATCH][next] treewide: uapi: Replace zero-length arrays with flexib

To: Kees Cook <keescook@xxxxxxxxxxxx>
Subject: Re: [PATCH][next] treewide: uapi: Replace zero-length arrays with flexible-array members
Cc: Daniel Borkmann <daniel@xxxxxxxxxxxxx>, "Gustavo A. R. Silva" <gustavoars@xxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, x86@xxxxxxxxxx, dm-devel@xxxxxxxxxx, linux-m68k@xxxxxxxxxxxxxxxxxxxx, linux-mips@xxxxxxxxxxxxxxx, linux-s390@xxxxxxxxxxxxxxx, kvm@xxxxxxxxxxxxxxx, intel-gfx@xxxxxxxxxxxxxxxxxxxxx, dri-devel@xxxxxxxxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, bpf@xxxxxxxxxxxxxxx, linux-btrfs@xxxxxxxxxxxxxxx, linux-can@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux1394-devel@xxxxxxxxxxxxxxxxxxxxx, io-uring@xxxxxxxxxxxxxxx, lvs-devel@xxxxxxxxxxxxxxx, linux-mtd@xxxxxxxxxxxxxxxxxxx, kasan-dev@xxxxxxxxxxxxxxxx, linux-mmc@xxxxxxxxxxxxxxx, nvdimm@xxxxxxxxxxxxxxx, netfilter-devel@xxxxxxxxxxxxxxx, coreteam@xxxxxxxxxxxxx, linux-perf-users@xxxxxxxxxxxxxxx, linux-raid@xxxxxxxxxxxxxxx, linux-sctp@xxxxxxxxxxxxxxx, linux-stm32@xxxxxxxxxxxxxxxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx, target-devel@xxxxxxxxxxxxxxx, linux-usb@xxxxxxxxxxxxxxx, virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx, v9fs-developer@xxxxxxxxxxxxxxxxxxxxx, linux-rdma@xxxxxxxxxxxxxxx, alsa-devel@xxxxxxxxxxxxxxxx, linux-hardening@xxxxxxxxxxxxxxx
From: Jason Gunthorpe <jgg@xxxxxxxx>
Date: Tue, 28 Jun 2022 15:44:04 -0300
On Tue, Jun 28, 2022 at 10:54:58AM -0700, Kees Cook wrote:

 
> which must also be assuming it's a header. So probably better to just
> drop the driver_data field? I don't see anything using it (that I can
> find) besides as a sanity-check that the field exists and is at the end
> of the struct.

The field is guaranteeing alignment of the following structure. IIRC
there are a few cases that we don't have a u64 already to force this.

Jason

<Prev in Thread] Current Thread [Next in Thread>