|
Hello,
On Wed, 2 Oct 2002, Roberto Nibali wrote:
> > + /* Many printk not good on SMP */
> > + printk("%s:", msg);
>
> You rate limit it, so it should be ok :)
Yes, but the whole message line is in many parts.
> > + h.th->rst? "R":"r");
>
> Two things:
> o Can you make it h.th->syn? "S" : "-"; instead of writing the 's'? This
> makes it more consistent with existing ipchains (I know it's 2.4.x but
> for the sake of completeness) printk's.
No, I will not change it :) '-' is not even 1 bit information
about what the flag is, you have to look at the sources.
> o Could you print out the URG and PSH flags too?
OK
> Best regards,
> Roberto Nibali, ratz
Regards
--
Julian Anastasov <ja@xxxxxx>
|
