Re: [PATCH] minor bug in ip_vs_ctl.c

[Wensong Zhang <wensong@xxxxxxxxxxxx>]

On Thu, 7 Nov 2002, Roberto Nibali wrote:

> 
> This is almost the same for ipvs-1.1.0. I wonder however, why some of 
> the calls do get back and call up(&__ip_vs_mutex) and some don't. It's a 
> very strange mix.
> 

Yes. It should not happen. *blush*  will fix it in ipvs-1.1.x soon.

> Let's see what Wensong thinks about it. What about adding the CMD length 
> check of the IP_VS_SO_GET_VERSION at the beginning too in ipvs-1.0.6?
> It would look nicer :)
> 
>          if (*len < get_arglen[GET_CMDID(cmd)]) {
>                  IP_VS_ERR("get_ctl: len %u < %u\n",
>                            *len, get_arglen[GET_CMDID(cmd)]);
>                  return -EINVAL;
>          }
> 

Well, I don't change too much in the ipvs-1.0.x series, as long as it can 
work correctly. The nicer code will be always in the latest code. :)

Cheers,

Wensong