LVS
lvs-users
Google
 
Web LinuxVirtualServer.org

Re: [PATCH-2.4] misc cleanup

To: "LinuxVirtualServer.org users mailing list." <lvs-users@xxxxxxxxxxxxxxxxxxxxxx>
Subject: Re: [PATCH-2.4] misc cleanup
From: Roberto Nibali <ratz@xxxxxxxxxxxx>
Date: Thu, 19 Jun 2003 01:48:36 +0200
Hi Peter,

Peter Mueller wrote:
Around line 43-54 on this patch don't you loose a }?  Maybe I'm going
boggle-eyed #:~O or something..

You got a bit loose with your quoting, however I think I didn't lose the '}' as it still compiles :)) :

root@laphish /data/lvs/ipvs-1.0.9-misc/ipvs # make
gcc -D__KERNEL__ -DMODULE -DEXPORT_SYMTAB -DMODVERSIONS -DCONFIG_IP_VS_DEBUG -g -O2 -Wall -Wstrict-prototypes -I/usr/src/linux/include -include /usr/src/linux/include/linux/modversions.h -c -o ip_vs_conn.o ip_vs_conn.c gcc -D__KERNEL__ -DMODULE -DEXPORT_SYMTAB -DMODVERSIONS -DCONFIG_IP_VS_DEBUG -g -O2 -Wall -Wstrict-prototypes -I/usr/src/linux/include -include /usr/src/linux/include/linux/modversions.h -c -o ip_vs_core.o ip_vs_core.c gcc -D__KERNEL__ -DMODULE -DEXPORT_SYMTAB -DMODVERSIONS -DCONFIG_IP_VS_DEBUG -g -O2 -Wall -Wstrict-prototypes -I/usr/src/linux/include -include /usr/src/linux/include/linux/modversions.h -c -o ip_vs_ctl.o ip_vs_ctl.c
make: *** [ip_vs_ctl.o] Interrupt

root@laphish /data/lvs/ipvs-1.0.9-misc/ipvs #

Maybe it looks like because I've changed:

if (dest) { ...

to

if (!dest)
        return;
...

Like this ip_vs_{un}bind_dest() will be equal and our pedantic ratz is happy :)

Best regards,
Roberto Nibali, ratz
--
echo '[q]sa[ln0=aln256%Pln256/snlbx]sb3135071790101768542287578439snlbxq'|dc

<Prev in Thread] Current Thread [Next in Thread>