|
Hi,
@@ -1669,7 +1669,7 @@
if (!(dname = addrport_to_anyname(&daddr, ntohs(e->port),
se->protocol, format)))
exit(1);
- if ((!format & FMT_RULE))
+ if (!(format & FMT_RULE))
dname[28] = '\0';
if (format & FMT_RULE) {
But I would expect the older one to be a bug corrected by the new
version.
In this case it's not exactly a bug, rather a feature ;). dname will
never get properly terminated which could lead to core dumps, however
this would require properly crafted strings. Like that you simply pass
non-terminated 60 byte strings to printf.
Am I right?
It should be corrected, yes. It does not influence the correct behaviour
of the user space tool in most cases. I should like to note that I would
really just like to synchronise the code, be it in user space for
ipvsadm or kernel space for ipvs.
Best regards,
Roberto Nibali, ratz
--
echo
'[q]sa[ln0=aln256%Pln256/snlbx]sb3135071790101768542287578439snlbxq' | dc
|
