Cool. Regression test :)
-----Original Message-----
From: lvs-users-bounces@xxxxxxxxxxxxxxxxxxxxxx
[mailto:lvs-users-bounces@xxxxxxxxxxxxxxxxxxxxxx] On Behalf Of Horms
Sent: 21 September 2005 10:58
To: LinuxVirtualServer.org users mailing list.
Subject: Re: ldirectord checktype=connect false positive
On Wed, Sep 21, 2005 at 05:41:28AM -0400, Purcocks, Graham wrote:
> Horm
>
> Do you need to test for a TCP check before dying? You may have removed
> this test for the UDP (SIP?) change. I don't know the logic but you
may
> break UDP again. I don't know whether an undef $sock is ok for UDP.
I think its ok. The SIP tests mainly involved UDP and they
worked, so I think the logic makes sense as it stands.
--
Horms
|