LVS
lvs-users
Google
 
Web LinuxVirtualServer.org

Re: patch for nasty ldirectord bug

To: "LinuxVirtualServer.org users mailing list." <lvs-users@xxxxxxxxxxxxxxxxxxxxxx>, Horms <horms@xxxxxxxxxxxx>
Subject: Re: patch for nasty ldirectord bug
From: Roberto Nibali <ratz@xxxxxx>
Date: Thu, 26 Jan 2006 16:55:20 +0100
Zdravo,

>> Patch:
>> Trivial patch is attached.
>>
>> Tested versions: 1.77.2.1 2004/04/20 05:05:29, 1.129 2006/01/15 16:25:19

So this needs to be applied to heartbeat 1 and 2.

> Well, it seems that mailing list manager ate patch file attachment, so here 
> it 
> is:

I seem to have the same problem with this mailing list lately.

> --- ldirectord.orig     2006-01-26 01:16:09.000000000 +0100
> +++ ldirectord  2006-01-26 01:17:09.000000000 +0100
> @@ -1475,8 +1475,8 @@
>  {
>         # Main failover checking code
>         while (1) {
> -               my @real_checked;
>                 foreach my $v (@VIRTUAL) {
> +                       my @real_checked;

Sranje! ;)

>                         my $real = $$v{real};
>                         my $virtual_id = get_virtual_id_str($v);

Obviously correct. This is indeed nasty. I've chased stupid bugs like
this before in my code. Horms is currently in NZ taking a well-deserved
vacation, so you might need to wait a bit for feedback.

Best regards,
Roberto Nibali, ratz
-- 
-------------------------------------------------------------
addr://Kasinostrasse 30, CH-5001 Aarau tel://++41 62 823 9355
http://www.terreactive.com             fax://++41 62 823 9356
-------------------------------------------------------------
10 Jahre Kompetenz in IT-Sicherheit.              1996 - 2006
Wir sichern Ihren Erfolg.                      terreActive AG
-------------------------------------------------------------

<Prev in Thread] Current Thread [Next in Thread>