|
* Julius Volz <juliusv@xxxxxxxxxx> 2008-07-10 13:20
> +/* IPVS genetlink family */
> +static struct genl_family ip_vs_genl_family = {
> + .id = GENL_ID_GENERATE,
> + .hdrsize = 0,
> + .name = IPVS_GENL_NAME,
> + .version = IPVS_GENL_VERSION,
> + .maxattr = IPVS_CMD_MAX
It's not a bug but looks like a typo, maxattr should
specify the number of first level attributes.
> +static int ip_vs_genl_dump_service(struct sk_buff *skb, struct ip_vs_service
> *svc,
> + struct netlink_callback *cb)
> +{
> + void *hdr;
> +
> + hdr = genlmsg_put(skb, NETLINK_CB(cb->skb).pid, cb->nlh->nlmsg_seq,
> + &ip_vs_genl_family, NLM_F_MULTI,
> + IPVS_CMD_GET_SERVICES);
Typically, netlink code follows the following semantics WRT to
commands/message types:
-> GET_SERVICE (NLM_F_DUMP)
<- NEW_SERVICE
<- NEW_SERVICE
<- NEW_SERVICE
If you are ever going to send notifications, you can use the very same
NEW_SERVICE and userspace can use the same parsing functions.
> +static int ip_vs_genl_get_cmd(struct sk_buff *skb, struct genl_info *info)
> +{
> + struct sk_buff *msg;
> + void *reply;
> + int ret, cmd;
> +
> + mutex_lock(&__ip_vs_mutex);
> +
> + cmd = info->genlhdr->cmd;
> +
> + msg = nlmsg_new(NLMSG_GOODSIZE, GFP_KERNEL);
This should be nlmsg_new(NLMSG_DEFAULT_SIZE, ...) , NLMSG_GOODSIZE is for use
with skb_alloc().
--
To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
|
